From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50868) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSo5z-0004jc-QM for qemu-devel@nongnu.org; Mon, 29 Oct 2012 08:05:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TSo5r-0004cw-DQ for qemu-devel@nongnu.org; Mon, 29 Oct 2012 08:05:31 -0400 Received: from 38.0.169.217.in-addr.arpa ([217.169.0.38]:40674 helo=mnementh.archaic.org.uk) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSo5r-0004cL-74 for qemu-devel@nongnu.org; Mon, 29 Oct 2012 08:05:23 -0400 From: Peter Maydell Date: Mon, 29 Oct 2012 12:05:08 +0000 Message-Id: <1351512311-19106-1-git-send-email-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PATCH 0/3] target-m68k/m68k-semi: don't ignore get/put_user failure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Blue Swirl , Meador Inge , Paul Brook , patches@linaro.org This patch series cleans up the m68k semihosting support to not ignore failure of get_user and put_user when reading semihosting arguments and writing return values (compare f296c0d1 which did something similar for ARM semihosting). The main motivation for this patch is to shut up clang's complaints about 'expression result unused'. Tested with a simple m68k hello world semihosting binary created with the CodeSourcery coldfire toolchain: ~/freescale-coldfire-2011.09/bin/m68k-elf-gcc -T m5206ec3-ram-hosted.ld -o /tmp/hello /tmp/hello.c -lc -lcs3hosted ./m68k-softmmu/qemu-system-m68k -semihosting -M dummy -display none -kernel /tmp/hello Meador's patch is already in qemu-trivial but I include it here as it is a dependency. Meador Inge (1): m68k: Return semihosting errno values correctly Peter Maydell (2): target-m68k/m68k-semi: Handle get_user failure target-m68k/m68k-semi.c: Log when put_user for returning values fails target-m68k/m68k-semi.c | 191 +++++++++++++++++++++++++++++++----------------- 1 file changed, 124 insertions(+), 67 deletions(-) -- 1.7.11.4