From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: Blue Swirl <blauwirbel@gmail.com>,
Meador Inge <meadori@codesourcery.com>,
Paul Brook <paul@codesourcery.com>,
patches@linaro.org
Subject: [Qemu-devel] [PATCH 1/3] m68k: Return semihosting errno values correctly
Date: Mon, 29 Oct 2012 12:05:09 +0000 [thread overview]
Message-ID: <1351512311-19106-2-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1351512311-19106-1-git-send-email-peter.maydell@linaro.org>
From: Meador Inge <meadori@codesourcery.com>
Fixing a simple typo, s/errno/err/, that caused
the error status from GDB semihosted system calls
to be returned incorrectly.
Signed-off-by: Meador Inge <meadori@codesourcery.com>
Reviewed-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
target-m68k/m68k-semi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-m68k/m68k-semi.c b/target-m68k/m68k-semi.c
index 3bb30cd..fed44ea 100644
--- a/target-m68k/m68k-semi.c
+++ b/target-m68k/m68k-semi.c
@@ -150,7 +150,7 @@ static void m68k_semi_cb(CPUM68KState *env, target_ulong ret, target_ulong err)
}
/* FIXME - handle put_user() failure */
put_user_u32(ret, args);
- put_user_u32(errno, args + 4);
+ put_user_u32(err, args + 4);
}
#define ARG(n) \
--
1.7.11.4
next prev parent reply other threads:[~2012-10-29 12:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-29 12:05 [Qemu-devel] [PATCH 0/3] target-m68k/m68k-semi: don't ignore get/put_user failure Peter Maydell
2012-10-29 12:05 ` Peter Maydell [this message]
2012-10-29 12:05 ` [Qemu-devel] [PATCH 2/3] target-m68k/m68k-semi: Handle get_user failure Peter Maydell
2012-10-29 12:05 ` [Qemu-devel] [PATCH 3/3] target-m68k/m68k-semi.c: Log when put_user for returning values fails Peter Maydell
2012-11-03 12:51 ` [Qemu-devel] [PATCH 0/3] target-m68k/m68k-semi: don't ignore get/put_user failure Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351512311-19106-2-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=blauwirbel@gmail.com \
--cc=meadori@codesourcery.com \
--cc=patches@linaro.org \
--cc=paul@codesourcery.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).