From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39001) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSq4j-0002pI-OZ for qemu-devel@nongnu.org; Mon, 29 Oct 2012 10:12:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TSq4a-0007JZ-39 for qemu-devel@nongnu.org; Mon, 29 Oct 2012 10:12:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:50667) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSq4Z-0007JB-Rj for qemu-devel@nongnu.org; Mon, 29 Oct 2012 10:12:12 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9TECB45031725 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 29 Oct 2012 10:12:11 -0400 From: Juan Quintela Date: Mon, 29 Oct 2012 15:11:36 +0100 Message-Id: <1351519903-26607-12-git-send-email-quintela@redhat.com> In-Reply-To: <1351519903-26607-1-git-send-email-quintela@redhat.com> References: <1351519903-26607-1-git-send-email-quintela@redhat.com> Subject: [Qemu-devel] [PATCH 11/18] buffered_file: don't flush on put buffer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: owasserm@redhat.com, mtosatti@redhat.com, avi@redhat.com, pbonzini@redhat.com We call buffered_put_buffer with iothread held, and buffered_flush() does synchronous writes. We only want to do the synchronous writes outside. Signed-off-by: Juan Quintela --- buffered_file.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/buffered_file.c b/buffered_file.c index 018cab7..2bdda27 100644 --- a/buffered_file.c +++ b/buffered_file.c @@ -107,12 +107,6 @@ static int buffered_put_buffer(void *opaque, const uint8_t *buf, int64_t pos, in buffered_append(s, buf, size); } - error = buffered_flush(s); - if (error < 0) { - DPRINTF("buffered flush error. bailing: %s\n", strerror(-error)); - return error; - } - return size; } -- 1.7.11.7