From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: owasserm@redhat.com, mtosatti@redhat.com, avi@redhat.com,
pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH 17/18] ram: Use memory_region_test_and_clear_dirty
Date: Mon, 29 Oct 2012 15:11:42 +0100 [thread overview]
Message-ID: <1351519903-26607-18-git-send-email-quintela@redhat.com> (raw)
In-Reply-To: <1351519903-26607-1-git-send-email-quintela@redhat.com>
This avoids having to do two walks over the dirty bitmap, one reading
the dirty bits, and another cleaning them.
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
arch_init.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/arch_init.c b/arch_init.c
index 1eefef8..79f466f 100644
--- a/arch_init.c
+++ b/arch_init.c
@@ -385,13 +385,12 @@ static void migration_bitmap_sync(void)
QLIST_FOREACH(block, &ram_list.blocks, next) {
for (addr = 0; addr < block->length; addr += TARGET_PAGE_SIZE) {
- if (memory_region_get_dirty(block->mr, addr, TARGET_PAGE_SIZE,
- DIRTY_MEMORY_MIGRATION)) {
+ if (memory_region_test_and_clear_dirty(block->mr,
+ addr, TARGET_PAGE_SIZE,
+ DIRTY_MEMORY_MIGRATION)) {
migration_bitmap_set_dirty(block->mr, addr);
}
}
- memory_region_reset_dirty(block->mr, 0, block->length,
- DIRTY_MEMORY_MIGRATION);
}
trace_migration_bitmap_sync_end(migration_dirty_pages
- num_dirty_pages_init);
--
1.7.11.7
next prev parent reply other threads:[~2012-10-29 14:12 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-29 14:11 [Qemu-devel] [PATCH 00/18] Migration thread lite (20121029) Juan Quintela
2012-10-29 14:11 ` [Qemu-devel] [PATCH 01/18] split MRU ram list Juan Quintela
2012-10-29 14:11 ` [Qemu-devel] [PATCH 02/18] add a version number to ram_list Juan Quintela
2012-10-29 14:11 ` [Qemu-devel] [PATCH 03/18] protect the ramlist with a separate mutex Juan Quintela
2012-10-29 14:11 ` [Qemu-devel] [PATCH 04/18] buffered_file: Move from using a timer to use a thread Juan Quintela
2012-10-29 14:11 ` [Qemu-devel] [PATCH 05/18] migration: make qemu_fopen_ops_buffered() return void Juan Quintela
2012-10-29 14:11 ` [Qemu-devel] [PATCH 06/18] migration: stop all cpus correctly Juan Quintela
2012-10-29 14:11 ` [Qemu-devel] [PATCH 07/18] migration: make writes blocking Juan Quintela
2012-10-29 15:51 ` Markus Armbruster
2012-10-29 17:32 ` Juan Quintela
2012-10-29 22:13 ` Paolo Bonzini
2012-10-30 7:36 ` Markus Armbruster
2012-10-30 8:23 ` Juan Quintela
2012-10-30 10:50 ` Markus Armbruster
2012-10-30 11:08 ` Juan Quintela
2012-10-29 14:11 ` [Qemu-devel] [PATCH 08/18] migration: remove unfreeze logic Juan Quintela
2012-10-29 14:11 ` [Qemu-devel] [PATCH 09/18] migration: take finer locking Juan Quintela
2012-10-29 14:11 ` [Qemu-devel] [PATCH 10/18] buffered_file: Unfold the trick to restart generating migration data Juan Quintela
2012-10-29 14:11 ` [Qemu-devel] [PATCH 11/18] buffered_file: don't flush on put buffer Juan Quintela
2012-10-29 14:11 ` [Qemu-devel] [PATCH 12/18] buffered_file: unfold buffered_append in buffered_put_buffer Juan Quintela
2012-10-29 14:11 ` [Qemu-devel] [PATCH 13/18] savevm: New save live migration method: pending Juan Quintela
2012-10-29 14:11 ` [Qemu-devel] [PATCH 14/18] migration: include qemu-file.h Juan Quintela
2012-10-29 14:11 ` [Qemu-devel] [PATCH 15/18] migration-fd: remove duplicate include Juan Quintela
2012-10-29 14:11 ` [Qemu-devel] [PATCH 16/18] memory: introduce memory_region_test_and_clear_dirty Juan Quintela
2012-10-29 14:11 ` Juan Quintela [this message]
2012-10-29 14:11 ` [Qemu-devel] [PATCH 18/18] ram: optimize migration bitmap walking Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351519903-26607-18-git-send-email-quintela@redhat.com \
--to=quintela@redhat.com \
--cc=avi@redhat.com \
--cc=mtosatti@redhat.com \
--cc=owasserm@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).