From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:39080) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSq4t-0003J7-0F for qemu-devel@nongnu.org; Mon, 29 Oct 2012 10:12:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TSq4n-0007NY-51 for qemu-devel@nongnu.org; Mon, 29 Oct 2012 10:12:30 -0400 Received: from mx1.redhat.com ([209.132.183.28]:28329) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TSq4m-0007NT-S3 for qemu-devel@nongnu.org; Mon, 29 Oct 2012 10:12:25 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id q9TECOMM031891 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 29 Oct 2012 10:12:24 -0400 From: Juan Quintela Date: Mon, 29 Oct 2012 15:11:42 +0100 Message-Id: <1351519903-26607-18-git-send-email-quintela@redhat.com> In-Reply-To: <1351519903-26607-1-git-send-email-quintela@redhat.com> References: <1351519903-26607-1-git-send-email-quintela@redhat.com> Subject: [Qemu-devel] [PATCH 17/18] ram: Use memory_region_test_and_clear_dirty List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: owasserm@redhat.com, mtosatti@redhat.com, avi@redhat.com, pbonzini@redhat.com This avoids having to do two walks over the dirty bitmap, one reading the dirty bits, and another cleaning them. Signed-off-by: Juan Quintela --- arch_init.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/arch_init.c b/arch_init.c index 1eefef8..79f466f 100644 --- a/arch_init.c +++ b/arch_init.c @@ -385,13 +385,12 @@ static void migration_bitmap_sync(void) QLIST_FOREACH(block, &ram_list.blocks, next) { for (addr = 0; addr < block->length; addr += TARGET_PAGE_SIZE) { - if (memory_region_get_dirty(block->mr, addr, TARGET_PAGE_SIZE, - DIRTY_MEMORY_MIGRATION)) { + if (memory_region_test_and_clear_dirty(block->mr, + addr, TARGET_PAGE_SIZE, + DIRTY_MEMORY_MIGRATION)) { migration_bitmap_set_dirty(block->mr, addr); } } - memory_region_reset_dirty(block->mr, 0, block->length, - DIRTY_MEMORY_MIGRATION); } trace_migration_bitmap_sync_end(migration_dirty_pages - num_dirty_pages_init); -- 1.7.11.7