From: Avi Kivity <avi@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
Alexander Graf <agraf@suse.de>, Blue Swirl <blauwirbel@gmail.com>,
Alex Williamson <alex.williamson@redhat.com>,
Anthony Liguori <anthony@codemonkey.ws>
Subject: [Qemu-devel] [PATCH v2 7/7] i440fx: add an iommu
Date: Tue, 30 Oct 2012 13:47:50 +0200 [thread overview]
Message-ID: <1351597670-23031-8-git-send-email-avi@redhat.com> (raw)
In-Reply-To: <1351597670-23031-1-git-send-email-avi@redhat.com>
This iommu encrypts addresses on the device bus to avoid divuling information
to hackers equipped with bus analyzers. Following 3DES, addresses are encrypted
multiple times. A XOR cypher is employed for efficiency.
Signed-off-by: Avi Kivity <avi@redhat.com>
---
hw/piix_pci.c | 77 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 77 insertions(+)
diff --git a/hw/piix_pci.c b/hw/piix_pci.c
index 9af5847..99601f4 100644
--- a/hw/piix_pci.c
+++ b/hw/piix_pci.c
@@ -30,6 +30,7 @@
#include "sysbus.h"
#include "range.h"
#include "xen.h"
+#include "exec-memory.h"
/*
* I440FX chipset data sheet.
@@ -248,6 +249,81 @@ static int i440fx_initfn(PCIDevice *dev)
return 0;
}
+typedef struct SillyIOMMU SillyIOMMU;
+
+struct SillyIOMMU {
+ MemoryRegion fault;
+ MemoryRegion l1;
+ MemoryRegion l2;
+ hwaddr mask;
+ hwaddr secret;
+};
+
+static IOMMUTLBEntry silly_l1_translate(MemoryRegion *l1, hwaddr addr)
+{
+ SillyIOMMU *s = container_of(l1, SillyIOMMU, l1);
+ hwaddr xlat = addr ^ s->secret;
+
+ printf("l1: %" HWADDR_PRIx " -> %" HWADDR_PRIx "\n", addr, xlat);
+
+ return (IOMMUTLBEntry) {
+ .device_addr = addr & ~s->mask,
+ .translated_addr = xlat & ~s->mask,
+ .addr_mask = s->mask,
+ .perm = { true, true },
+ };
+}
+
+static MemoryRegionIOMMUOps silly_l1_iommu_ops = {
+ .translate = silly_l1_translate,
+};
+
+static IOMMUTLBEntry silly_l2_translate(MemoryRegion *l2, hwaddr addr)
+{
+ SillyIOMMU *s = container_of(l2, SillyIOMMU, l2);
+ hwaddr xlat = addr ^ s->secret;
+
+ printf("l2: %" HWADDR_PRIx " -> %" HWADDR_PRIx "\n", addr, xlat);
+
+ return (IOMMUTLBEntry) {
+ .device_addr = addr & ~s->mask,
+ .translated_addr = xlat & ~s->mask,
+ .addr_mask = s->mask,
+ .perm = { true, true },
+ };
+}
+
+static MemoryRegionIOMMUOps silly_l2_iommu_ops = {
+ .translate = silly_l2_translate,
+};
+
+static MemoryRegion *silly_iommu_new(PCIBus *bus, void *opaque, int devfn)
+{
+ SillyIOMMU *s = g_new(SillyIOMMU, 1);
+ MemoryRegion *sysmem = get_system_memory();
+
+ s->mask = (0x1000 << (devfn >> 3)) - 1;
+ s->secret = ((devfn << 24) | 0x00aabbccdd) & ~s->mask;
+ memory_region_init(&s->fault, "silly-fault", INT64_MAX);
+ memory_region_init_iommu(&s->l2, &silly_l2_iommu_ops, sysmem, &s->fault,
+ "silly-l2", INT64_MAX);
+ memory_region_init_iommu(&s->l1, &silly_l1_iommu_ops, &s->l2, &s->fault,
+ "silly-l1", INT64_MAX);
+ return &s->l1;
+}
+
+static void silly_iommu_del(MemoryRegion *l1)
+{
+ SillyIOMMU *s = container_of(l1, SillyIOMMU, l1);
+
+ memory_region_del_subregion(&s->l2, get_system_memory());
+ memory_region_del_subregion(&s->l1, &s->l2);
+ memory_region_destroy(&s->l2);
+ memory_region_destroy(&s->l1);
+ memory_region_destroy(&s->fault);
+ g_free(s);
+}
+
static PCIBus *i440fx_common_init(const char *device_name,
PCII440FXState **pi440fx_state,
int *piix3_devfn,
@@ -275,6 +351,7 @@ static PCIBus *i440fx_common_init(const char *device_name,
s->address_space = address_space_mem;
b = pci_bus_new(dev, NULL, pci_address_space,
address_space_io, 0);
+ pci_setup_iommu(b, silly_iommu_new, silly_iommu_del, NULL);
s->bus = b;
object_property_add_child(qdev_get_machine(), "i440fx", OBJECT(dev), NULL);
qdev_init_nofail(dev);
--
1.7.12
next prev parent reply other threads:[~2012-10-30 11:48 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 11:47 [Qemu-devel] [PATCH v2 0/7] IOMMU support Avi Kivity
2012-10-30 11:47 ` [Qemu-devel] [PATCH v2 1/7] memory: fix address space initialization/destruction Avi Kivity
2012-10-30 11:47 ` [Qemu-devel] [PATCH v2 2/7] memory: limit sections in the radix tree to the actual address space size Avi Kivity
2012-10-30 11:47 ` [Qemu-devel] [PATCH v2 3/7] memory: iommu support Avi Kivity
2012-10-30 19:11 ` Blue Swirl
2012-10-30 20:03 ` Benjamin Herrenschmidt
2012-10-30 21:13 ` Blue Swirl
2012-10-31 10:32 ` Avi Kivity
2012-10-31 18:59 ` Benjamin Herrenschmidt
2012-11-01 13:44 ` Avi Kivity
2012-11-01 13:45 ` Avi Kivity
2012-10-30 11:47 ` [Qemu-devel] [PATCH v2 4/7] memory: provide a MemoryRegion for IOMMUs to log faults Avi Kivity
2012-10-30 19:14 ` Blue Swirl
2012-10-31 10:33 ` Avi Kivity
2012-10-30 11:47 ` [Qemu-devel] [PATCH v2 5/7] pci: use memory core for iommu support Avi Kivity
2012-10-30 11:47 ` [Qemu-devel] [PATCH v2 6/7] vfio: abort if an emulated iommu is used Avi Kivity
2012-10-30 11:47 ` Avi Kivity [this message]
2012-10-30 19:18 ` [Qemu-devel] [PATCH v2 7/7] i440fx: add an iommu Blue Swirl
2012-10-31 10:34 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351597670-23031-8-git-send-email-avi@redhat.com \
--to=avi@redhat.com \
--cc=agraf@suse.de \
--cc=alex.williamson@redhat.com \
--cc=anthony@codemonkey.ws \
--cc=blauwirbel@gmail.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).