From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34525) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTWKd-0008Nw-1c for qemu-devel@nongnu.org; Wed, 31 Oct 2012 07:19:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TTWKc-0002bJ-2h for qemu-devel@nongnu.org; Wed, 31 Oct 2012 07:19:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37413) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TTWKb-0002ZP-Qj for qemu-devel@nongnu.org; Wed, 31 Oct 2012 07:19:34 -0400 From: Orit Wasserman Date: Wed, 31 Oct 2012 13:19:41 +0200 Message-Id: <1351682381-8793-1-git-send-email-owasserm@redhat.com> Subject: [Qemu-devel] [PATCH] Fix calculation of number of bits in the migration bitmap List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: pbonzini@redhat.com, aliguori@us.ibm.com, Orit Wasserman , avi@redhat.com, quintela@redhat.com The number of bits is off by one, for example if last_ram_offset is 0x1000 (the guest has one page) we get 0 bits instead of 1. Signed-off-by: Orit Wasserman --- arch_init.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch_init.c b/arch_init.c index b75a4c5..a80c3c8 100644 --- a/arch_init.c +++ b/arch_init.c @@ -565,7 +565,7 @@ static void reset_ram_globals(void) static int ram_save_setup(QEMUFile *f, void *opaque) { RAMBlock *block; - int64_t ram_pages = last_ram_offset() >> TARGET_PAGE_BITS; + int64_t ram_pages = (last_ram_offset() >> TARGET_PAGE_BITS) + 1; migration_bitmap = bitmap_new(ram_pages); bitmap_set(migration_bitmap, 0, ram_pages); -- 1.7.11.7