qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, aliguori@us.ibm.com,
	blauwirbel@gmail.com, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH 14/28] qapi: add visit_type_long()
Date: Wed, 31 Oct 2012 17:35:58 -0500	[thread overview]
Message-ID: <1351722972-17801-15-git-send-email-mdroth@linux.vnet.ibm.com> (raw)
In-Reply-To: <1351722972-17801-1-git-send-email-mdroth@linux.vnet.ibm.com>


Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
 qapi/qapi-visit-core.c |   18 ++++++++++++++++++
 qapi/qapi-visit-core.h |    3 +++
 2 files changed, 21 insertions(+)

diff --git a/qapi/qapi-visit-core.c b/qapi/qapi-visit-core.c
index dd28cb9..274361f 100644
--- a/qapi/qapi-visit-core.c
+++ b/qapi/qapi-visit-core.c
@@ -234,6 +234,24 @@ void visit_type_int64(Visitor *v, int64_t *obj, const char *name, Error **errp)
     }
 }
 
+void visit_type_long(Visitor *v, long *obj, const char *name, Error **errp)
+{
+    int64_t value;
+    if (!error_is_set(errp)) {
+        if (v->type_long) {
+            v->type_long(v, obj, name, errp);
+        } else {
+            value = *obj;
+            visit_type_int64(v, &value, name, errp);
+            if (value < LONG_MIN || value > LONG_MAX) {
+                error_set(errp, QERR_INVALID_PARAMETER_VALUE, name ? name : "null",
+                          "long");
+            }
+            *obj = value;
+        }
+    }
+}
+
 void visit_type_size(Visitor *v, uint64_t *obj, const char *name, Error **errp)
 {
     if (!error_is_set(errp)) {
diff --git a/qapi/qapi-visit-core.h b/qapi/qapi-visit-core.h
index 5eb1616..04058e7 100644
--- a/qapi/qapi-visit-core.h
+++ b/qapi/qapi-visit-core.h
@@ -64,6 +64,8 @@ struct Visitor
     void (*type_int16)(Visitor *v, int16_t *obj, const char *name, Error **errp);
     void (*type_int32)(Visitor *v, int32_t *obj, const char *name, Error **errp);
     void (*type_int64)(Visitor *v, int64_t *obj, const char *name, Error **errp);
+    /* visit_type_long() falls back to (*type_int64)() if type_long is unset */
+    void (*type_long)(Visitor *v, long *obj, const char *name, Error **errp);
     /* visit_type_size() falls back to (*type_uint64)() if type_size is unset */
     void (*type_size)(Visitor *v, uint64_t *obj, const char *name, Error **errp);
 };
@@ -91,6 +93,7 @@ void visit_type_int8(Visitor *v, int8_t *obj, const char *name, Error **errp);
 void visit_type_int16(Visitor *v, int16_t *obj, const char *name, Error **errp);
 void visit_type_int32(Visitor *v, int32_t *obj, const char *name, Error **errp);
 void visit_type_int64(Visitor *v, int64_t *obj, const char *name, Error **errp);
+void visit_type_long(Visitor *v, long *obj, const char *name, Error **errp);
 void visit_type_size(Visitor *v, uint64_t *obj, const char *name, Error **errp);
 void visit_type_bool(Visitor *v, bool *obj, const char *name, Error **errp);
 void visit_type_str(Visitor *v, char **obj, const char *name, Error **errp);
-- 
1.7.9.5

  parent reply	other threads:[~2012-10-31 22:36 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-31 22:35 [Qemu-devel] [PATCH v6 00/28] Add infrastructure for QIDL-based device serialization (Happy Halloween Edition) Michael Roth
2012-10-31 22:35 ` [Qemu-devel] [PATCH 01/28] qapi: qapi-visit.py -> qapi_visit.py so we can import Michael Roth
2012-10-31 22:35 ` [Qemu-devel] [PATCH 02/28] qapi: qapi-types.py -> qapi_types.py Michael Roth
2012-10-31 22:35 ` [Qemu-devel] [PATCH 03/28] qapi: qapi-commands.py -> qapi_commands.py Michael Roth
2012-10-31 22:35 ` [Qemu-devel] [PATCH 04/28] qapi: qapi_visit.py, make code useable as module Michael Roth
2012-10-31 22:35 ` [Qemu-devel] [PATCH 05/28] qapi: qapi_visit.py, support arrays and complex qapi definitions Michael Roth
2012-10-31 22:35 ` [Qemu-devel] [PATCH 06/28] qapi: qapi_visit.py, support generating static functions Michael Roth
2012-10-31 22:35 ` [Qemu-devel] [PATCH 07/28] qapi: qapi_visit.py, support for visiting non-pointer/embedded structs Michael Roth
2012-10-31 22:35 ` [Qemu-devel] [PATCH 08/28] qapi: qapi_visit.py, support for q_string annotations Michael Roth
2012-10-31 22:35 ` [Qemu-devel] [PATCH 09/28] qapi: add visitor interfaces for C arrays Michael Roth
2012-10-31 22:35 ` [Qemu-devel] [PATCH 10/28] qapi: QmpOutputVisitor, implement array handling Michael Roth
2012-10-31 22:35 ` [Qemu-devel] [PATCH 11/28] qapi: QmpInputVisitor, " Michael Roth
2012-10-31 22:35 ` [Qemu-devel] [PATCH 12/28] qapi: QmpInputVisitor, don't re-allocate memory in start_struct Michael Roth
2012-10-31 22:35 ` [Qemu-devel] [PATCH 13/28] qapi: fix potential segfault for visit_type_size() Michael Roth
2012-10-31 22:35 ` Michael Roth [this message]
2012-10-31 22:35 ` [Qemu-devel] [PATCH 15/28] qapi: ordereddict, add to_json() method Michael Roth
2012-10-31 22:36 ` [Qemu-devel] [PATCH 16/28] qapi: qapi.py, make json parser more robust Michael Roth
2012-10-31 22:36 ` [Qemu-devel] [PATCH 17/28] qapi: add open-coded visitors for struct tm/Int128 types Michael Roth
2012-10-31 22:36 ` [Qemu-devel] [PATCH 18/28] qapi: Improve existing docs and document annotated QAPI types Michael Roth
2012-10-31 22:36 ` [Qemu-devel] [PATCH 19/28] qom-fuse: force single-threaded mode to avoid QMP races Michael Roth
2012-10-31 22:36 ` [Qemu-devel] [PATCH 20/28] qom-fuse: workaround for truncated properties > 4096 Michael Roth
2012-10-31 22:36 ` [Qemu-devel] [PATCH 21/28] module additions for schema registration Michael Roth
2012-10-31 22:36 ` [Qemu-devel] [PATCH 22/28] qdev: move Property-related declarations to qdev-properties.h Michael Roth
2012-10-31 22:36 ` [Qemu-devel] [PATCH 23/28] qidl: add documentation Michael Roth
2012-10-31 22:36 ` [Qemu-devel] [PATCH 24/28] qidl: add lexer library (based on QC parser) Michael Roth
2012-10-31 22:36 ` [Qemu-devel] [PATCH 25/28] qidl: add C parser " Michael Roth
2012-10-31 22:36 ` [Qemu-devel] [PATCH 26/28] qidl: add QAPI-based code generator Michael Roth
2012-10-31 22:36 ` [Qemu-devel] [PATCH 27/28] qidl: qidl.h, definitions for qidl annotations Michael Roth
2012-10-31 22:36 ` [Qemu-devel] [PATCH 28/28] qidl: unit tests and build infrastructure Michael Roth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1351722972-17801-15-git-send-email-mdroth@linux.vnet.ibm.com \
    --to=mdroth@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=blauwirbel@gmail.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).