From: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH V5 00/10] replace QEMUOptionParameter with QemuOpts parser
Date: Thu, 1 Nov 2012 17:12:20 +0800 [thread overview]
Message-ID: <1351761150-20705-1-git-send-email-wdongxu@linux.vnet.ibm.com> (raw)
Patch 1-3 are from Luiz, added Markus's comments, discussion could be found here:
http://lists.nongnu.org/archive/html/qemu-devel/2012-07/msg02716.html
Patch 3 was changed according Paolo's comments.
Patch 4-5: because qemu_opts_create can not fail while id is null, so create
function qemu_opts_create_nofail and use it.
Patch 6: create function qemu_opt_set_number, like qemu_opt_set_bool.
Patch 7: add def_value and use it in qemu_opts_print.
Patch 8: Create functions to pair with QEMUOptionParameter parser.
Patch 9: Use QemuOpts parser in Block.
Patch 10: Remove QEMUOptionParameter parser related code.
v4->v5:
1) Rewrite qemu_opts_create_nofail function based on Peter Maydell's comments.
2) Use g_strdup_printf in qemu_opt_set_number.
3) Rewrite qemu_opts_print.
4) .bdrv_create_options returns pointer directly. Fix a bug about "encryption".
5) Check qemu_opt_get_number in raw-posix.c.
v3->v4:
1) Rebased to the newest source tree.
2) Remove redundant "#include "block-cache.h"
3) Other small changes.
v2->v3:
1) rewrite qemu_opt_set_bool and qemu_opt_set_number according Paolo's coments.
2) split patches to make review easier.
v1->v2:
1) add Luiz's patches.
2) create qemu_opt_set_number() and qemu_opts_create_nofail() functions.
3) add QemuOptsList map to drivers.
4) use original opts parser, not creating new ones.
5) fix other bugs.
Luiz Capitulino (2):
qemu-option: opt_set(): split it up into more functions
qemu-option: qemu_opts_validate(): fix duplicated code
Dong Xu Wang (8):
qemu-option: qemu_opt_set_bool(): fix code duplication
introduce qemu_opts_create_nofail function
use qemu_opts_create_nofail
create new function: qemu_opt_set_number
add def_value and use it in qemu_opts_print.
Create four opts list related functions
Use QemuOpts support in block layer
remove QEMUOptionParameter related functions and struct
block.c | 91 +++++-----
block.h | 8 +-
block/cow.c | 46 +++---
block/qcow.c | 60 +++----
block/qcow2.c | 171 +++++++++---------
block/qed.c | 86 +++++-----
block/raw-posix.c | 65 +++----
block/raw.c | 22 ++-
block/sheepdog.c | 75 ++++----
block/vdi.c | 68 ++++----
block/vmdk.c | 74 ++++----
block/vpc.c | 51 +++---
block/vvfat.c | 11 +-
block_int.h | 6 +-
blockdev.c | 2 +-
hw/watchdog.c | 2 +-
qemu-config.c | 4 +-
qemu-img.c | 63 +++----
qemu-option.c | 512 ++++++++++++++++++-----------------------------------
qemu-option.h | 39 +----
qemu-sockets.c | 16 +-
vl.c | 12 +-
22 files changed, 637 insertions(+), 847 deletions(-)
next reply other threads:[~2012-11-01 9:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 9:12 Dong Xu Wang [this message]
2012-11-01 9:12 ` [Qemu-devel] [PATCH V5 01/10] qemu-option: opt_set(): split it up into more functions Dong Xu Wang
2012-11-01 9:12 ` [Qemu-devel] [PATCH V5 02/10] qemu-option: qemu_opts_validate(): fix duplicated code Dong Xu Wang
2012-11-01 9:12 ` [Qemu-devel] [PATCH V5 03/10] qemu-option: qemu_opt_set_bool(): fix code duplication Dong Xu Wang
2012-11-01 9:12 ` [Qemu-devel] [PATCH V5 04/10] introduce qemu_opts_create_nofail function Dong Xu Wang
2012-11-01 9:12 ` [Qemu-devel] [PATCH V5 05/10] use qemu_opts_create_nofail Dong Xu Wang
2012-11-01 9:12 ` [Qemu-devel] [PATCH V5 06/10] create new function: qemu_opt_set_number Dong Xu Wang
2012-11-01 9:12 ` [Qemu-devel] [PATCH V5 07/10] add def_print_str and use it in qemu_opts_print Dong Xu Wang
2012-11-01 9:12 ` [Qemu-devel] [PATCH V5 08/10] Create four opts list related functions Dong Xu Wang
2012-11-19 17:16 ` Stefan Hajnoczi
2012-11-21 2:48 ` Dong Xu Wang
2012-11-01 9:12 ` [Qemu-devel] [PATCH V5 09/10] Use QemuOpts support in block layer Dong Xu Wang
2012-11-19 17:14 ` Stefan Hajnoczi
2012-11-21 2:51 ` Dong Xu Wang
2012-11-01 9:12 ` [Qemu-devel] [PATCH V5 10/10] remove QEMUOptionParameter related functions and struct Dong Xu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351761150-20705-1-git-send-email-wdongxu@linux.vnet.ibm.com \
--to=wdongxu@linux.vnet.ibm.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).