qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, Dong Xu Wang <wdongxu@linux.vnet.ibm.com>,
	Luiz Capitulino <lcapitulino@redhat.com>
Subject: [Qemu-devel] [PATCH V5 02/10] qemu-option: qemu_opts_validate(): fix duplicated code
Date: Thu,  1 Nov 2012 17:12:22 +0800	[thread overview]
Message-ID: <1351761150-20705-3-git-send-email-wdongxu@linux.vnet.ibm.com> (raw)
In-Reply-To: <1351761150-20705-1-git-send-email-wdongxu@linux.vnet.ibm.com>

Use opts_accepts_any() and find_desc_by_name().

Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
Signed-off-by: Dong Xu Wang <wdongxu@linux.vnet.ibm.com>
---
 qemu-option.c |   14 +++-----------
 1 files changed, 3 insertions(+), 11 deletions(-)

diff --git a/qemu-option.c b/qemu-option.c
index 375daaa..74321bb 100644
--- a/qemu-option.c
+++ b/qemu-option.c
@@ -1076,23 +1076,15 @@ void qemu_opts_validate(QemuOpts *opts, const QemuOptDesc *desc, Error **errp)
     QemuOpt *opt;
     Error *local_err = NULL;
 
-    assert(opts->list->desc[0].name == NULL);
+    assert(opts_accepts_any(opts));
 
     QTAILQ_FOREACH(opt, &opts->head, next) {
-        int i;
-
-        for (i = 0; desc[i].name != NULL; i++) {
-            if (strcmp(desc[i].name, opt->name) == 0) {
-                break;
-            }
-        }
-        if (desc[i].name == NULL) {
+        opt->desc = find_desc_by_name(desc, opt->name);
+        if (!opt->desc) {
             error_set(errp, QERR_INVALID_PARAMETER, opt->name);
             return;
         }
 
-        opt->desc = &desc[i];
-
         qemu_opt_parse(opt, &local_err);
         if (error_is_set(&local_err)) {
             error_propagate(errp, local_err);
-- 
1.7.1

  parent reply	other threads:[~2012-11-01  9:13 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-01  9:12 [Qemu-devel] [PATCH V5 00/10] replace QEMUOptionParameter with QemuOpts parser Dong Xu Wang
2012-11-01  9:12 ` [Qemu-devel] [PATCH V5 01/10] qemu-option: opt_set(): split it up into more functions Dong Xu Wang
2012-11-01  9:12 ` Dong Xu Wang [this message]
2012-11-01  9:12 ` [Qemu-devel] [PATCH V5 03/10] qemu-option: qemu_opt_set_bool(): fix code duplication Dong Xu Wang
2012-11-01  9:12 ` [Qemu-devel] [PATCH V5 04/10] introduce qemu_opts_create_nofail function Dong Xu Wang
2012-11-01  9:12 ` [Qemu-devel] [PATCH V5 05/10] use qemu_opts_create_nofail Dong Xu Wang
2012-11-01  9:12 ` [Qemu-devel] [PATCH V5 06/10] create new function: qemu_opt_set_number Dong Xu Wang
2012-11-01  9:12 ` [Qemu-devel] [PATCH V5 07/10] add def_print_str and use it in qemu_opts_print Dong Xu Wang
2012-11-01  9:12 ` [Qemu-devel] [PATCH V5 08/10] Create four opts list related functions Dong Xu Wang
2012-11-19 17:16   ` Stefan Hajnoczi
2012-11-21  2:48     ` Dong Xu Wang
2012-11-01  9:12 ` [Qemu-devel] [PATCH V5 09/10] Use QemuOpts support in block layer Dong Xu Wang
2012-11-19 17:14   ` Stefan Hajnoczi
2012-11-21  2:51     ` Dong Xu Wang
2012-11-01  9:12 ` [Qemu-devel] [PATCH V5 10/10] remove QEMUOptionParameter related functions and struct Dong Xu Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1351761150-20705-3-git-send-email-wdongxu@linux.vnet.ibm.com \
    --to=wdongxu@linux.vnet.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).