From: Alexander Graf <agraf@suse.de>
To: qemu-devel qemu-devel <qemu-devel@nongnu.org>
Cc: Blue Swirl <blauwirbel@gmail.com>,
"qemu-ppc@nongnu.org List" <qemu-ppc@nongnu.org>,
Aurelien Jarno <aurelien@aurel32.net>,
David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PATCH 4/5] pseries: Clean up inconsistent variable name in xics.c
Date: Thu, 1 Nov 2012 13:07:16 +0100 [thread overview]
Message-ID: <1351771637-20685-5-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1351771637-20685-1-git-send-email-agraf@suse.de>
From: David Gibson <david@gibson.dropbear.id.au>
Throughout xics.c 'nr' is used to refer to a global interrupt number, and
'server' is used to refer to an interrupt server number (i.e. CPU number).
Except in icp_set_mfrr(), where 'nr' is used as a server number. Fix this
confusing inconsistency.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Alexander Graf <agraf@suse.de>
---
hw/xics.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/hw/xics.c b/hw/xics.c
index ce88aa7..7a899dd 100644
--- a/hw/xics.c
+++ b/hw/xics.c
@@ -108,13 +108,13 @@ static void icp_set_cppr(struct icp_state *icp, int server, uint8_t cppr)
}
}
-static void icp_set_mfrr(struct icp_state *icp, int nr, uint8_t mfrr)
+static void icp_set_mfrr(struct icp_state *icp, int server, uint8_t mfrr)
{
- struct icp_server_state *ss = icp->ss + nr;
+ struct icp_server_state *ss = icp->ss + server;
ss->mfrr = mfrr;
if (mfrr < CPPR(ss)) {
- icp_check_ipi(icp, nr);
+ icp_check_ipi(icp, server);
}
}
--
1.6.0.2
next prev parent reply other threads:[~2012-11-01 12:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 12:07 [Qemu-devel] [PULL 0/5] ppc patch queue 2012-11-01 Alexander Graf
2012-11-01 12:07 ` [Qemu-devel] [PATCH 1/5] Revert "PPC: pseries: Remove hack for PIO window" Alexander Graf
2012-11-01 12:07 ` [Qemu-devel] [PATCH 2/5] target-ppc: Rework storage of VPA registration state Alexander Graf
2012-11-01 12:07 ` [Qemu-devel] [PATCH 3/5] target-ppc: Extend FPU state for newer POWER CPUs Alexander Graf
2012-11-01 12:07 ` Alexander Graf [this message]
2012-11-01 12:07 ` [Qemu-devel] [PATCH 5/5] pseries: Cleanup duplications of ics_valid_irq() code Alexander Graf
2012-11-01 16:03 ` [Qemu-devel] [PULL 0/5] ppc patch queue 2012-11-01 Aurelien Jarno
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351771637-20685-5-git-send-email-agraf@suse.de \
--to=agraf@suse.de \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).