qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Hans de Goede <hdegoede@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 31/31] usb-redir: Allow redirecting super speed devices to high speed controllers
Date: Thu,  1 Nov 2012 16:54:44 +0100	[thread overview]
Message-ID: <1351785284-15384-32-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1351785284-15384-1-git-send-email-kraxel@redhat.com>

From: Hans de Goede <hdegoede@redhat.com>

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/usb/redirect.c |   23 +++++++++++++++++++++--
 1 files changed, 21 insertions(+), 2 deletions(-)

diff --git a/hw/usb/redirect.c b/hw/usb/redirect.c
index 8d4d3f4..c5cfe0b 100644
--- a/hw/usb/redirect.c
+++ b/hw/usb/redirect.c
@@ -1071,7 +1071,7 @@ static int usbredir_initfn(USBDevice *udev)
     udev->auto_attach = 0;
 
     /* Will be cleared during setup when we find conflicts */
-    dev->compatible_speedmask = USB_SPEED_MASK_FULL;
+    dev->compatible_speedmask = USB_SPEED_MASK_FULL | USB_SPEED_MASK_HIGH;
 
     /* Let the backend know we are ready */
     qemu_chr_fe_open(dev->cs);
@@ -1214,10 +1214,12 @@ static void usbredir_device_connect(void *priv,
         speed = "low speed";
         dev->dev.speed = USB_SPEED_LOW;
         dev->compatible_speedmask &= ~USB_SPEED_MASK_FULL;
+        dev->compatible_speedmask &= ~USB_SPEED_MASK_HIGH;
         break;
     case usb_redir_speed_full:
         speed = "full speed";
         dev->dev.speed = USB_SPEED_FULL;
+        dev->compatible_speedmask &= ~USB_SPEED_MASK_HIGH;
         break;
     case usb_redir_speed_high:
         speed = "high speed";
@@ -1287,7 +1289,7 @@ static void usbredir_device_disconnect(void *priv)
     dev->interface_info.interface_count = NO_INTERFACE_INFO;
     dev->dev.addr = 0;
     dev->dev.speed = 0;
-    dev->compatible_speedmask = USB_SPEED_MASK_FULL;
+    dev->compatible_speedmask = USB_SPEED_MASK_FULL | USB_SPEED_MASK_HIGH;
 }
 
 static void usbredir_interface_info(void *priv,
@@ -1364,6 +1366,7 @@ static void usbredir_ep_info(void *priv,
             break;
         case usb_redir_type_iso:
             usbredir_mark_speed_incompatible(dev, USB_SPEED_FULL);
+            usbredir_mark_speed_incompatible(dev, USB_SPEED_HIGH);
             /* Fall through */
         case usb_redir_type_interrupt:
             if (!usbredirparser_peer_has_cap(dev->parser,
@@ -1371,6 +1374,11 @@ static void usbredir_ep_info(void *priv,
                     ep_info->max_packet_size[i] > 64) {
                 usbredir_mark_speed_incompatible(dev, USB_SPEED_FULL);
             }
+            if (!usbredirparser_peer_has_cap(dev->parser,
+                                     usb_redir_cap_ep_info_max_packet_size) ||
+                    ep_info->max_packet_size[i] > 1024) {
+                usbredir_mark_speed_incompatible(dev, USB_SPEED_HIGH);
+            }
             if (dev->endpoint[i].interval == 0) {
                 ERROR("Received 0 interval for isoc or irq endpoint\n");
                 usbredir_reject_device(dev);
@@ -1501,6 +1509,17 @@ static void usbredir_control_packet(void *priv, uint64_t id,
     DPRINTF("ctrl-in status %d len %d id %"PRIu64"\n", control_packet->status,
             len, id);
 
+    /* Fix up USB-3 ep0 maxpacket size to allow superspeed connected devices
+     * to work redirected to a not superspeed capable hcd */
+    if (dev->dev.speed == USB_SPEED_SUPER &&
+            !((dev->dev.port->speedmask & USB_SPEED_MASK_SUPER)) &&
+            control_packet->requesttype == 0x80 &&
+            control_packet->request == 6 &&
+            control_packet->value == 0x100 && control_packet->index == 0 &&
+            data_len >= 18 && data[7] == 9) {
+        data[7] = 64;
+    }
+
     p = usbredir_find_packet_by_id(dev, 0, id);
     if (p) {
         len = usbredir_handle_status(dev, control_packet->status, len);
-- 
1.7.1

      parent reply	other threads:[~2012-11-01 15:54 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-01 15:54 [Qemu-devel] [PULL 00/31] usb patch queue Gerd Hoffmann
2012-11-01 15:54 ` [Qemu-devel] [PATCH 01/31] xhci: add {get, set}_field macros & enum for pls Gerd Hoffmann
2012-11-01 15:54 ` [Qemu-devel] [PATCH 02/31] xhci: s/xhci_update_port/xhci_port_update/ Gerd Hoffmann
2012-11-01 15:54 ` [Qemu-devel] [PATCH 03/31] xhci: add xhci_port_have_device Gerd Hoffmann
2012-11-01 15:54 ` [Qemu-devel] [PATCH 04/31] xhci: add xhci_port_notify Gerd Hoffmann
2012-11-01 15:54 ` [Qemu-devel] [PATCH 05/31] xhci: add xhci_port_reset Gerd Hoffmann
2012-11-01 15:54 ` [Qemu-devel] [PATCH 06/31] xhci: set pls in xhci_port_update & xhci_port_reset Gerd Hoffmann
2012-11-01 15:54 ` [Qemu-devel] [PATCH 07/31] xhci: add port trace points Gerd Hoffmann
2012-11-01 15:54 ` [Qemu-devel] [PATCH 08/31] xhci: allow address slot being called multiple times Gerd Hoffmann
2012-11-01 15:54 ` [Qemu-devel] [PATCH 09/31] usb/ehci: parameterise the register region offsets Gerd Hoffmann
2012-11-01 15:54 ` [Qemu-devel] [PATCH 10/31] usb/ehci: Abstract away PCI DMA API Gerd Hoffmann
2012-11-01 15:54 ` [Qemu-devel] [PATCH 11/31] usb/ehci: seperate out PCIisms Gerd Hoffmann
2012-11-01 15:54 ` [Qemu-devel] [PATCH 12/31] usb/ehci: Guard definition of EHCI_DEBUG Gerd Hoffmann
2012-11-01 15:54 ` [Qemu-devel] [PATCH 13/31] usb/ehci: split into multiple source files Gerd Hoffmann
2012-11-01 15:54 ` [Qemu-devel] [PATCH 14/31] usb/ehci: add sysbus variant Gerd Hoffmann
2012-11-01 15:54 ` [Qemu-devel] [PATCH 15/31] xilinx_zynq: add USB controllers Gerd Hoffmann
2012-11-01 15:54 ` [Qemu-devel] [PATCH 16/31] uhci: dynamic type generation Gerd Hoffmann
2012-11-01 15:54 ` [Qemu-devel] [PATCH 17/31] uhci: stick irq routing info into UHCIInfo too Gerd Hoffmann
2012-11-01 15:54 ` [Qemu-devel] [PATCH 18/31] uhci: add ich9 00:1a.* variants Gerd Hoffmann
2012-11-01 15:54 ` [Qemu-devel] [PATCH 19/31] usb/ehci-pci: dynamic type generation Gerd Hoffmann
2012-11-01 15:54 ` [Qemu-devel] [PATCH 20/31] usb/ehci-pci: add ich9 00:1a.* variant Gerd Hoffmann
2012-11-01 15:54 ` [Qemu-devel] [PATCH 21/31] usb/ehci-pci: add helper to create ich9 usb controllers Gerd Hoffmann
2012-11-01 15:54 ` [Qemu-devel] [PATCH 22/31] uhci: Add a uhci_handle_td_error() helper function Gerd Hoffmann
2012-11-01 15:54 ` [Qemu-devel] [PATCH 23/31] uhci: Don't crash on device disconnect Gerd Hoffmann
2012-11-01 15:54 ` [Qemu-devel] [PATCH 24/31] usb: Add packet combining functions Gerd Hoffmann
2012-11-01 15:54 ` [Qemu-devel] [PATCH 25/31] combined-packet: Add a workaround for Linux usbfs + live migration Gerd Hoffmann
2012-11-01 15:54 ` [Qemu-devel] [PATCH 26/31] usb-redir: Add support for 32 bits bulk packet length Gerd Hoffmann
2012-11-01 15:54 ` [Qemu-devel] [PATCH 27/31] usb-redir: Add support for input pipelining Gerd Hoffmann
2012-11-01 15:54 ` [Qemu-devel] [PATCH 28/31] usb-redir: Add an usbredir_setup_usb_eps() helper function Gerd Hoffmann
2012-11-01 15:54 ` [Qemu-devel] [PATCH 29/31] usb-redir: Use reject rather the disconnect on bad ep info Gerd Hoffmann
2012-11-01 15:54 ` [Qemu-devel] [PATCH 30/31] usb-redir: Allow to attach USB 2.0 devices to 1.1 host controller Gerd Hoffmann
2012-11-01 15:54 ` Gerd Hoffmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1351785284-15384-32-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=hdegoede@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).