From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TU05d-00065A-OC for qemu-devel@nongnu.org; Thu, 01 Nov 2012 15:06:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TU05c-0007PA-Ce for qemu-devel@nongnu.org; Thu, 01 Nov 2012 15:06:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58306) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TU05c-0007P2-4E for qemu-devel@nongnu.org; Thu, 01 Nov 2012 15:06:04 -0400 From: Stefan Hajnoczi Date: Thu, 1 Nov 2012 20:05:40 +0100 Message-Id: <1351796754-21703-2-git-send-email-stefanha@redhat.com> In-Reply-To: <1351796754-21703-1-git-send-email-stefanha@redhat.com> References: <1351796754-21703-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH 1/9] cadence_uart: More debug information List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Peter Crosthwaite , qemu-devel@nongnu.org, Stefan Hajnoczi From: Peter Crosthwaite Add more helpful debug information to the cadence UART. Signed-off-by: Peter Crosthwaite Reviewed-by: Peter Maydell Signed-off-by: Stefan Hajnoczi --- hw/cadence_uart.c | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/cadence_uart.c b/hw/cadence_uart.c index a7d0504..686e617 100644 --- a/hw/cadence_uart.c +++ b/hw/cadence_uart.c @@ -359,7 +359,7 @@ static void uart_write(void *opaque, hwaddr offset, { UartState *s = (UartState *)opaque; - DB_PRINT(" offset:%x data:%08x\n", offset, (unsigned)value); + DB_PRINT(" offset:%x data:%08x\n", (unsigned)offset, (unsigned)value); offset >>= 2; switch (offset) { case R_IER: /* ier (wts imr) */ @@ -405,12 +405,15 @@ static uint64_t uart_read(void *opaque, hwaddr offset, offset >>= 2; if (offset >= R_MAX) { - return 0; + c = 0; } else if (offset == R_TX_RX) { uart_read_rx_fifo(s, &c); - return c; + } else { + c = s->r[offset]; } - return s->r[offset]; + + DB_PRINT(" offset:%x data:%08x\n", (unsigned)(offset << 2), (unsigned)c); + return c; } static const MemoryRegionOps uart_ops = { -- 1.7.12.1