qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Joel Martin <github@martintribe.org>,
	qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH 1/6] ui/vnc: Only report/use TIGHT_PNG encoding if enabled.
Date: Thu,  1 Nov 2012 20:05:41 +0100	[thread overview]
Message-ID: <1351796754-21703-3-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1351796754-21703-1-git-send-email-stefanha@redhat.com>

From: Joel Martin <github@martintribe.org>

If TIGHT_PNG is not enabled by the --enable-vnc-png configure flag
then do not report to the client that it is supported.

Also, since TIGHT_PNG is the same as the TIGHT encoding but with the
filter/copy replaced with PNG data, adding it to the supported
encodings list when it is disabled will cause the TIGHT encoding to be
used even though the client requested TIGHT_PNG.

Signed-off-by: Joel Martin <github@martintribe.org>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
 ui/vnc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/ui/vnc.c b/ui/vnc.c
index 33e6386..66ae930 100644
--- a/ui/vnc.c
+++ b/ui/vnc.c
@@ -1806,10 +1806,12 @@ static void set_encodings(VncState *vs, int32_t *encodings, size_t n_encodings)
             vs->features |= VNC_FEATURE_TIGHT_MASK;
             vs->vnc_encoding = enc;
             break;
+#ifdef CONFIG_VNC_PNG
         case VNC_ENCODING_TIGHT_PNG:
             vs->features |= VNC_FEATURE_TIGHT_PNG_MASK;
             vs->vnc_encoding = enc;
             break;
+#endif
         case VNC_ENCODING_ZLIB:
             vs->features |= VNC_FEATURE_ZLIB_MASK;
             vs->vnc_encoding = enc;
-- 
1.7.11.7

  parent reply	other threads:[~2012-11-01 19:06 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-01 19:05 [Qemu-devel] [PULL 1.3 0/9] Trivial patches for 20 October to 1 November 2012 Stefan Hajnoczi
2012-11-01 19:05 ` [Qemu-devel] [PATCH 1/9] cadence_uart: More debug information Stefan Hajnoczi
2012-11-01 19:05 ` Stefan Hajnoczi [this message]
2012-11-01 19:05 ` [Qemu-devel] [PATCH 2/9] m68k: Return semihosting errno values correctly Stefan Hajnoczi
2012-11-01 19:05 ` [Qemu-devel] [PATCH 2/6] targphys.h: Don't define target_phys_addr_t for user-mode emulators Stefan Hajnoczi
2012-11-01 19:05 ` [Qemu-devel] [PATCH 3/6] target-arm/neon_helper: Remove obsolete FIXME comment Stefan Hajnoczi
2012-11-01 19:05 ` [Qemu-devel] [PATCH 3/9] target-sparc: make do_unaligned_access static Stefan Hajnoczi
2012-11-01 19:05 ` [Qemu-devel] [PATCH 4/6] configure: Remove unused parameters from main function Stefan Hajnoczi
2012-11-01 19:05 ` [Qemu-devel] [PATCH 4/9] vl.c: add missing static Stefan Hajnoczi
2012-11-01 19:05 ` [Qemu-devel] [PATCH 5/6] net/tap-win32: Fix compiler warning caused by missing include statement Stefan Hajnoczi
2012-11-01 19:05 ` [Qemu-devel] [PATCH 5/9] vnc: add missing static Stefan Hajnoczi
2012-11-01 19:05 ` [Qemu-devel] [PATCH 6/9] ppc: " Stefan Hajnoczi
2012-11-01 19:05 ` [Qemu-devel] [PATCH 6/6] ui/vnc-jobs.c: Fix minor typos in comments Stefan Hajnoczi
2012-11-01 19:05 ` [Qemu-devel] [PATCH 7/9] target-ppc: make some functions static Stefan Hajnoczi
2012-11-01 19:05 ` [Qemu-devel] [PATCH 8/9] exec: " Stefan Hajnoczi
2012-11-01 19:05 ` [Qemu-devel] [PATCH 9/9] pc: Drop redundant test for ROM memory region Stefan Hajnoczi
2012-11-03 15:19 ` [Qemu-devel] [PULL 1.3 0/9] Trivial patches for 20 October to 1 November 2012 Blue Swirl
  -- strict thread matches above, loose matches on Subject: below --
2012-10-19  8:54 [Qemu-devel] [PULL 0/6] Trivial patches for 13 to 19 October 2012 Stefan Hajnoczi
2012-10-19  8:54 ` [Qemu-devel] [PATCH 1/6] ui/vnc: Only report/use TIGHT_PNG encoding if enabled Stefan Hajnoczi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1351796754-21703-3-git-send-email-stefanha@redhat.com \
    --to=stefanha@redhat.com \
    --cc=aliguori@us.ibm.com \
    --cc=github@martintribe.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).