From: Stefan Hajnoczi <stefanha@redhat.com>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Blue Swirl <blauwirbel@gmail.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: [Qemu-devel] [PATCH 4/9] vl.c: add missing static
Date: Thu, 1 Nov 2012 20:05:47 +0100 [thread overview]
Message-ID: <1351796754-21703-9-git-send-email-stefanha@redhat.com> (raw)
In-Reply-To: <1351796754-21703-1-git-send-email-stefanha@redhat.com>
From: Blue Swirl <blauwirbel@gmail.com>
Add missing 'static' qualifiers.
Signed-off-by: Blue Swirl <blauwirbel@gmail.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
sysemu.h | 5 -----
vl.c | 21 ++++++++++++---------
2 files changed, 12 insertions(+), 14 deletions(-)
diff --git a/sysemu.h b/sysemu.h
index f72b4ce..f5ac664 100644
--- a/sysemu.h
+++ b/sysemu.h
@@ -19,7 +19,6 @@ extern uint8_t qemu_uuid[];
int qemu_uuid_parse(const char *str, uint8_t *uuid);
#define UUID_FMT "%02hhx%02hhx%02hhx%02hhx-%02hhx%02hhx-%02hhx%02hhx-%02hhx%02hhx-%02hhx%02hhx%02hhx%02hhx%02hhx%02hhx"
-void runstate_init(void);
bool runstate_check(RunState state);
void runstate_set(RunState new_state);
int runstate_is_running(void);
@@ -57,11 +56,7 @@ void qemu_system_debug_request(void);
void qemu_system_vmstop_request(RunState reason);
int qemu_shutdown_requested_get(void);
int qemu_reset_requested_get(void);
-int qemu_shutdown_requested(void);
-int qemu_reset_requested(void);
-int qemu_powerdown_requested(void);
void qemu_system_killed(int signal, pid_t pid);
-void qemu_kill_report(void);
void qemu_devices_reset(void);
void qemu_system_reset(bool report);
diff --git a/vl.c b/vl.c
index 5513d15..d840c32 100644
--- a/vl.c
+++ b/vl.c
@@ -180,7 +180,7 @@ static const char *data_dir;
const char *bios_name = NULL;
enum vga_retrace_method vga_retrace_method = VGA_RETRACE_DUMB;
DisplayType display_type = DT_DEFAULT;
-int display_remote = 0;
+static int display_remote;
const char* keyboard_layout = NULL;
ram_addr_t ram_size;
const char *mem_path = NULL;
@@ -214,7 +214,7 @@ const char *vnc_display;
int acpi_enabled = 1;
int no_hpet = 0;
int fd_bootchk = 1;
-int no_reboot = 0;
+static int no_reboot;
int no_shutdown = 0;
int cursor_hide = 1;
int graphic_rotate = 0;
@@ -242,7 +242,8 @@ struct FWBootEntry {
char *suffix;
};
-QTAILQ_HEAD(, FWBootEntry) fw_boot_order = QTAILQ_HEAD_INITIALIZER(fw_boot_order);
+static QTAILQ_HEAD(, FWBootEntry) fw_boot_order =
+ QTAILQ_HEAD_INITIALIZER(fw_boot_order);
int nb_numa_nodes;
uint64_t node_mem[MAX_NODES];
@@ -396,7 +397,7 @@ bool runstate_check(RunState state)
return current_run_state == state;
}
-void runstate_init(void)
+static void runstate_init(void)
{
const RunStateTransition *p;
@@ -1457,14 +1458,14 @@ int qemu_reset_requested_get(void)
return reset_requested;
}
-int qemu_shutdown_requested(void)
+static int qemu_shutdown_requested(void)
{
int r = shutdown_requested;
shutdown_requested = 0;
return r;
}
-void qemu_kill_report(void)
+static void qemu_kill_report(void)
{
if (!qtest_enabled() && shutdown_signal != -1) {
fprintf(stderr, "qemu: terminating on signal %d", shutdown_signal);
@@ -1480,7 +1481,7 @@ void qemu_kill_report(void)
}
}
-int qemu_reset_requested(void)
+static int qemu_reset_requested(void)
{
int r = reset_requested;
reset_requested = 0;
@@ -1501,7 +1502,7 @@ static int qemu_wakeup_requested(void)
return r;
}
-int qemu_powerdown_requested(void)
+static int qemu_powerdown_requested(void)
{
int r = powerdown_requested;
powerdown_requested = 0;
@@ -2127,7 +2128,9 @@ struct device_config {
Location loc;
QTAILQ_ENTRY(device_config) next;
};
-QTAILQ_HEAD(, device_config) device_configs = QTAILQ_HEAD_INITIALIZER(device_configs);
+
+static QTAILQ_HEAD(, device_config) device_configs =
+ QTAILQ_HEAD_INITIALIZER(device_configs);
static void add_device_config(int type, const char *cmdline)
{
--
1.7.12.1
next prev parent reply other threads:[~2012-11-01 19:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-01 19:05 [Qemu-devel] [PULL 1.3 0/9] Trivial patches for 20 October to 1 November 2012 Stefan Hajnoczi
2012-11-01 19:05 ` [Qemu-devel] [PATCH 1/9] cadence_uart: More debug information Stefan Hajnoczi
2012-11-01 19:05 ` [Qemu-devel] [PATCH 1/6] ui/vnc: Only report/use TIGHT_PNG encoding if enabled Stefan Hajnoczi
2012-11-01 19:05 ` [Qemu-devel] [PATCH 2/9] m68k: Return semihosting errno values correctly Stefan Hajnoczi
2012-11-01 19:05 ` [Qemu-devel] [PATCH 2/6] targphys.h: Don't define target_phys_addr_t for user-mode emulators Stefan Hajnoczi
2012-11-01 19:05 ` [Qemu-devel] [PATCH 3/6] target-arm/neon_helper: Remove obsolete FIXME comment Stefan Hajnoczi
2012-11-01 19:05 ` [Qemu-devel] [PATCH 3/9] target-sparc: make do_unaligned_access static Stefan Hajnoczi
2012-11-01 19:05 ` [Qemu-devel] [PATCH 4/6] configure: Remove unused parameters from main function Stefan Hajnoczi
2012-11-01 19:05 ` Stefan Hajnoczi [this message]
2012-11-01 19:05 ` [Qemu-devel] [PATCH 5/6] net/tap-win32: Fix compiler warning caused by missing include statement Stefan Hajnoczi
2012-11-01 19:05 ` [Qemu-devel] [PATCH 5/9] vnc: add missing static Stefan Hajnoczi
2012-11-01 19:05 ` [Qemu-devel] [PATCH 6/9] ppc: " Stefan Hajnoczi
2012-11-01 19:05 ` [Qemu-devel] [PATCH 6/6] ui/vnc-jobs.c: Fix minor typos in comments Stefan Hajnoczi
2012-11-01 19:05 ` [Qemu-devel] [PATCH 7/9] target-ppc: make some functions static Stefan Hajnoczi
2012-11-01 19:05 ` [Qemu-devel] [PATCH 8/9] exec: " Stefan Hajnoczi
2012-11-01 19:05 ` [Qemu-devel] [PATCH 9/9] pc: Drop redundant test for ROM memory region Stefan Hajnoczi
2012-11-03 15:19 ` [Qemu-devel] [PULL 1.3 0/9] Trivial patches for 20 October to 1 November 2012 Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351796754-21703-9-git-send-email-stefanha@redhat.com \
--to=stefanha@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).