[Qemu-devel] [PATCH 0/3] trivial: Remove some pre-TCG CPUArchState members

[Qemu-devel] [PATCH 0/3] trivial: Remove some pre-TCG CPUArchState members

[Richard Henderson]

Best I can figure, these temporaries were used by the dyngen
code generator, last seen in qemu 0.9.0.  Certainly there are
no references to these members remaining.

Built x86_64 and i686 hosts.


r~


Richard Henderson (3):
  target-alpha: Remove t0, t1 from CPUAlphaState
  target-m68k: Remove t1 from CPUM68KState
  target-sparc: Remove t0, t1 from CPUSPARCState

 target-alpha/cpu.h | 7 -------
 target-m68k/cpu.h  | 3 ---
 target-sparc/cpu.h | 1 -
 3 files changed, 11 deletions(-)

-- 
1.7.11.7

[Qemu-devel] [PATCH 1/3] target-alpha: Remove t0, t1 from CPUAlphaState

[Richard Henderson]

These fields are no longer (or were never?) used.

Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 target-alpha/cpu.h | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/target-alpha/cpu.h b/target-alpha/cpu.h
index 34221fb..9939d61 100644
--- a/target-alpha/cpu.h
+++ b/target-alpha/cpu.h
@@ -280,13 +280,6 @@ struct CPUAlphaState {
     struct QEMUTimer *alarm_timer;
     uint64_t alarm_expire;
 
-#if TARGET_LONG_BITS > HOST_LONG_BITS
-    /* temporary fixed-point registers
-     * used to emulate 64 bits target on 32 bits hosts
-     */
-    target_ulong t0, t1;
-#endif
-
     /* Those resources are used only in QEMU core */
     CPU_COMMON
 
-- 
1.7.11.7

[Qemu-devel] [PATCH 2/3] target-m68k: Remove t1 from CPUM68KState

[Richard Henderson]

This field is no longer used.

Cc: Paul Brook <paul@codesourcery.com>
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 target-m68k/cpu.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/target-m68k/cpu.h b/target-m68k/cpu.h
index 780e2c9..f4fcdee 100644
--- a/target-m68k/cpu.h
+++ b/target-m68k/cpu.h
@@ -103,9 +103,6 @@ typedef struct CPUM68KState {
     uint32_t rambar0;
     uint32_t cacr;
 
-    /* ??? remove this.  */
-    uint32_t t1;
-
     int pending_vector;
     int pending_level;
 
-- 
1.7.11.7

[Qemu-devel] [PATCH 3/3] target-sparc: Remove t0, t1 from CPUSPARCState

[Richard Henderson]

These fields are no longer used.

Cc: Blue Swirl <blauwirbel@gmail.com>
Signed-off-by: Richard Henderson <rth@twiddle.net>
---
 target-sparc/cpu.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/target-sparc/cpu.h b/target-sparc/cpu.h
index 6aa82b3..84dba4e 100644
--- a/target-sparc/cpu.h
+++ b/target-sparc/cpu.h
@@ -392,7 +392,6 @@ struct CPUSPARCState {
     target_ulong cc_dst;
     uint32_t cc_op;
 
-    target_ulong t0, t1; /* temporaries live across basic blocks */
     target_ulong cond; /* conditional branch result (XXX: save it in a
                           temporary register when possible) */
 
-- 
1.7.11.7

Re: [Qemu-devel] [PATCH 0/3] trivial: Remove some pre-TCG CPUArchState members

[Richard Henderson]

Ping.

On 2012-11-01 14:36, Richard Henderson wrote:
> Best I can figure, these temporaries were used by the dyngen
> code generator, last seen in qemu 0.9.0.  Certainly there are
> no references to these members remaining.
> 
> Built x86_64 and i686 hosts.
> 
> 
> r~
> 
> 
> Richard Henderson (3):
>   target-alpha: Remove t0, t1 from CPUAlphaState
>   target-m68k: Remove t1 from CPUM68KState
>   target-sparc: Remove t0, t1 from CPUSPARCState
> 
>  target-alpha/cpu.h | 7 -------
>  target-m68k/cpu.h  | 3 ---
>  target-sparc/cpu.h | 1 -
>  3 files changed, 11 deletions(-)
> 

Re: [Qemu-devel] [PATCH 0/3] trivial: Remove some pre-TCG CPUArchState members

[Andreas Färber]

Am 21.11.2012 17:51, schrieb Richard Henderson:
> Ping.

I had a brief look at these when you posted this, and it's generally
fine with me. I just didn't get around to testing/verifying yet.

Not sure if this fits our current Hard Freeze definition though. ;)

Andreas

> 
> On 2012-11-01 14:36, Richard Henderson wrote:
>> Best I can figure, these temporaries were used by the dyngen
>> code generator, last seen in qemu 0.9.0.  Certainly there are
>> no references to these members remaining.
>>
>> Built x86_64 and i686 hosts.
>>
>>
>> r~
>>
>>
>> Richard Henderson (3):
>>   target-alpha: Remove t0, t1 from CPUAlphaState
>>   target-m68k: Remove t1 from CPUM68KState
>>   target-sparc: Remove t0, t1 from CPUSPARCState
>>
>>  target-alpha/cpu.h | 7 -------
>>  target-m68k/cpu.h  | 3 ---
>>  target-sparc/cpu.h | 1 -
>>  3 files changed, 11 deletions(-)

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg

Re: [Qemu-devel] [PATCH 0/3] trivial: Remove some pre-TCG CPUArchState members

[Richard Henderson]

On 2012-11-21 09:09, Andreas Färber wrote:
> Not sure if this fits our current Hard Freeze definition though. ;)

How often do I need to ping patches to get them applied?
I've generally been waiting 1-2 weeks between pings.
I've got at least 5 minor patch sets outstanding, dating
back to at least late September.

I hope for the next release there's both soft and hard
freeze periods, and much more help from those with commit
privs in reducing the outstanding patch queues before we
decide on "done".


r~

Re: [Qemu-devel] [PATCH 0/3] trivial: Remove some pre-TCG CPUArchState members

[Peter Maydell]

On 21 November 2012 18:23, Richard Henderson <rth@twiddle.net> wrote:
> On 2012-11-21 09:09, Andreas Färber wrote:
>> Not sure if this fits our current Hard Freeze definition though. ;)
>
> How often do I need to ping patches to get them applied?
> I've generally been waiting 1-2 weeks between pings.
> I've got at least 5 minor patch sets outstanding, dating
> back to at least late September.

My rule of thumb is a week or so between pings, yes.

> I hope for the next release there's both soft and hard
> freeze periods, and much more help from those with commit
> privs in reducing the outstanding patch queues before we
> decide on "done".

There was a soft freeze period: 1st Nov to 19 Nov. I
don't personally expect trivial patches sent after the
soft freeze to be applied before release, so this one
missing the boat is not very surprising. Patches dating
back to September are a different story :-(

-- PMM

Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/3] trivial: Remove some pre-TCG CPUArchState members

[Stefan Hajnoczi]

On Fri, Nov 02, 2012 at 08:36:34AM +1100, Richard Henderson wrote:
> Best I can figure, these temporaries were used by the dyngen
> code generator, last seen in qemu 0.9.0.  Certainly there are
> no references to these members remaining.
> 
> Built x86_64 and i686 hosts.
> 
> 
> r~
> 
> 
> Richard Henderson (3):
>   target-alpha: Remove t0, t1 from CPUAlphaState
>   target-m68k: Remove t1 from CPUM68KState
>   target-sparc: Remove t0, t1 from CPUSPARCState
> 
>  target-alpha/cpu.h | 7 -------
>  target-m68k/cpu.h  | 3 ---
>  target-sparc/cpu.h | 1 -
>  3 files changed, 11 deletions(-)
> 
> -- 
> 1.7.11.7
> 
> 

Sorry I missed your pull request.

Thanks, applied to the trivial patches tree and should get in once the
1.4 merge window opens:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan