qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 4/7] qxl: call dpy_gfx_resize when entering vga mode
Date: Fri,  2 Nov 2012 10:35:16 +0100	[thread overview]
Message-ID: <1351848919-10388-5-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1351848919-10388-1-git-send-email-kraxel@redhat.com>

When entering vga mode the display size likely changes,
notify all displaychangelisteners about this.

Probably went unnoticed for a while as one if the first
things the guest does after leaving qxl native mode and
entering qxl vga mode is to set the vga video mode.  But
there is still a small window where qemu can operate on
stale data, leading to crashes now and then.

https://bugzilla.redhat.com/show_bug.cgi?id=865767

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/qxl.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/hw/qxl.c b/hw/qxl.c
index 063970d..e7bf3a1 100644
--- a/hw/qxl.c
+++ b/hw/qxl.c
@@ -1069,7 +1069,7 @@ static void qxl_enter_vga_mode(PCIQXLDevice *d)
     trace_qxl_enter_vga_mode(d->id);
     qemu_spice_create_host_primary(&d->ssd);
     d->mode = QXL_MODE_VGA;
-    memset(&d->ssd.dirty, 0, sizeof(d->ssd.dirty));
+    dpy_gfx_resize(d->ssd.ds);
     vga_dirty_log_start(&d->vga);
 }
 
-- 
1.7.1

  parent reply	other threads:[~2012-11-02  9:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-02  9:35 [Qemu-devel] [PULL 0/7] spice patch queue Gerd Hoffmann
2012-11-02  9:35 ` [Qemu-devel] [PATCH 1/7] hw/qxl: guest bug on primary create with stride %4 != 0 Gerd Hoffmann
2012-11-02  9:35 ` [Qemu-devel] [PATCH 2/7] hw/qxl: qxl_send_events: nop if stopped Gerd Hoffmann
2012-11-02  9:35 ` [Qemu-devel] [PATCH 3/7] qxl: fix cursor reset Gerd Hoffmann
2012-11-02  9:35 ` Gerd Hoffmann [this message]
2012-11-02  9:35 ` [Qemu-devel] [PATCH 5/7] spice: switch to pixman Gerd Hoffmann
2012-11-02  9:35 ` [Qemu-devel] [PATCH 6/7] pflib: unused, remove it Gerd Hoffmann
2012-11-02  9:35 ` [Qemu-devel] [PATCH 7/7] spice: fix initialization order Gerd Hoffmann
2012-11-05 12:29 ` [Qemu-devel] [PULL 0/7] spice patch queue Gerd Hoffmann
2012-11-14 16:21 ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1351848919-10388-5-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).