From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59034) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TUKy9-0001Dp-Ns for qemu-devel@nongnu.org; Fri, 02 Nov 2012 13:23:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TUKy8-0004k4-3z for qemu-devel@nongnu.org; Fri, 02 Nov 2012 13:23:45 -0400 Received: from cantor2.suse.de ([195.135.220.15]:38866 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TUKy7-0004ju-Pt for qemu-devel@nongnu.org; Fri, 02 Nov 2012 13:23:44 -0400 From: =?UTF-8?q?Andreas=20F=C3=A4rber?= Date: Fri, 2 Nov 2012 18:23:33 +0100 Message-Id: <1351877013-25751-2-git-send-email-afaerber@suse.de> In-Reply-To: <1351877013-25751-1-git-send-email-afaerber@suse.de> References: <1351877013-25751-1-git-send-email-afaerber@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH] target-i386: cpu: fix --disable-kvm compilation List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Eduardo Habkost , anthony@codemonkey.ws, =?UTF-8?q?Andreas=20F=C3=A4rber?= From: Eduardo Habkost This fixes the following: target-i386/cpu.o: In function `kvm_cpu_fill_host': target-i386/cpu.c:783: undefined reference to `kvm_state' I didn't notice the problem before because GCC was optimizing the entire kvm_cpu_fill_host() function out (because all calls are conditional on kvm_enabled()). * cpu_x86_fill_model_id() is used only if CONFIG_KVM is set, so #ifdef it entirely to avoid compiler warnings. * kvm_cpu_fill_host() should be called only if KVM is enabled, so use #ifdef CONFIG_KVM around the entire function body. Reported-by: Andreas F=C3=A4rber Signed-off-by: Eduardo Habkost Signed-off-by: Andreas F=C3=A4rber --- target-i386/cpu.c | 4 ++++ 1 Datei ge=C3=A4ndert, 4 Zeilen hinzugef=C3=BCgt(+) diff --git a/target-i386/cpu.c b/target-i386/cpu.c index c46286a..e1db639 100644 --- a/target-i386/cpu.c +++ b/target-i386/cpu.c @@ -758,6 +758,7 @@ static x86_def_t builtin_x86_defs[] =3D { }, }; =20 +#ifdef CONFIG_KVM static int cpu_x86_fill_model_id(char *str) { uint32_t eax =3D 0, ebx =3D 0, ecx =3D 0, edx =3D 0; @@ -772,6 +773,7 @@ static int cpu_x86_fill_model_id(char *str) } return 0; } +#endif =20 /* Fill a x86_def_t struct with information about the host CPU, and * the CPU features supported by the host hardware + host kernel @@ -780,6 +782,7 @@ static int cpu_x86_fill_model_id(char *str) */ static void kvm_cpu_fill_host(x86_def_t *x86_cpu_def) { +#ifdef CONFIG_KVM KVMState *s =3D kvm_state; uint32_t eax =3D 0, ebx =3D 0, ecx =3D 0, edx =3D 0; =20 @@ -838,6 +841,7 @@ static void kvm_cpu_fill_host(x86_def_t *x86_cpu_def) * unsupported ones later. */ x86_cpu_def->svm_features =3D -1; +#endif /* CONFIG_KVM */ } =20 static int unavailable_host_feature(struct model_features_t *f, uint32_t= mask) --=20 1.7.10.4