qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Hans de Goede <hdegoede@redhat.com>, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 5/8] xhci: Add support for packets with both data and an error status
Date: Fri,  9 Nov 2012 10:05:48 +0100	[thread overview]
Message-ID: <1352451951-9407-6-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1352451951-9407-1-git-send-email-kraxel@redhat.com>

From: Hans de Goede <hdegoede@redhat.com>

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 hw/usb/hcd-xhci.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/usb/hcd-xhci.c b/hw/usb/hcd-xhci.c
index d4a2e0c..a181d45 100644
--- a/hw/usb/hcd-xhci.c
+++ b/hw/usb/hcd-xhci.c
@@ -1388,7 +1388,7 @@ static void xhci_xfer_report(XHCITransfer *xfer)
     XHCIState *xhci = xfer->xhci;
     int i;
 
-    left = xfer->packet.status ? 0 : xfer->packet.actual_length;
+    left = xfer->packet.actual_length;
 
     for (i = 0; i < xfer->trb_count; i++) {
         XHCITRB *trb = &xfer->trbs[i];
@@ -1416,7 +1416,7 @@ static void xhci_xfer_report(XHCITransfer *xfer)
 
         if (!reported && ((trb->control & TRB_TR_IOC) ||
                           (shortpkt && (trb->control & TRB_TR_ISP)) ||
-                          (xfer->status != CC_SUCCESS))) {
+                          (xfer->status != CC_SUCCESS && left == 0))) {
             event.slotid = xfer->slotid;
             event.epid = xfer->epid;
             event.length = (trb->status & 0x1ffff) - chunk;
-- 
1.7.1

  parent reply	other threads:[~2012-11-09  9:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-09  9:05 [Qemu-devel] [PULL 0/8] usb patch queue Gerd Hoffmann
2012-11-09  9:05 ` [Qemu-devel] [PATCH 1/8] usb: split packet result into actual_length + status Gerd Hoffmann
2012-11-09  9:05 ` [Qemu-devel] [PATCH 2/8] usb-redir: Allow packets to have both data and an error-status Gerd Hoffmann
2012-11-09  9:05 ` [Qemu-devel] [PATCH 3/8] ehci: Get rid of the magical PROC_ERR status Gerd Hoffmann
2012-11-09  9:05 ` [Qemu-devel] [PATCH 4/8] ehci: Add support for packets with both data and an error status Gerd Hoffmann
2012-11-09  9:05 ` Gerd Hoffmann [this message]
2012-11-09  9:05 ` [Qemu-devel] [PATCH 6/8] usb/combined-packet: Move freeing of combined to usb_combined_packet_remove() Gerd Hoffmann
2012-11-09  9:05 ` [Qemu-devel] [PATCH 7/8] xhci: Fix some DMA host endian bugs Gerd Hoffmann
2012-11-09  9:05 ` [Qemu-devel] [PATCH 8/8] ehci: fix migration Gerd Hoffmann
2012-11-14 16:22 ` [Qemu-devel] [PULL 0/8] usb patch queue Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1352451951-9407-6-git-send-email-kraxel@redhat.com \
    --to=kraxel@redhat.com \
    --cc=hdegoede@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).