From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:55900) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TWq04-00075b-8E for qemu-devel@nongnu.org; Fri, 09 Nov 2012 09:56:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TWpzv-0005XM-26 for qemu-devel@nongnu.org; Fri, 09 Nov 2012 09:56:04 -0500 Received: from mx1.redhat.com ([209.132.183.28]:15073) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TWpzu-0005Wk-Oe for qemu-devel@nongnu.org; Fri, 09 Nov 2012 09:55:54 -0500 From: Eduardo Habkost Date: Fri, 9 Nov 2012 12:56:48 -0200 Message-Id: <1352473012-20500-21-git-send-email-ehabkost@redhat.com> In-Reply-To: <1352473012-20500-1-git-send-email-ehabkost@redhat.com> References: <1352473012-20500-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [PATCH 20/24] qdev: add weak aliases for vmstate handling on qdev.c List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: peter.maydell@linaro.org, riku.voipio@iki.fi, blauwirbel@gmail.com, Anthony Liguori , Igor Mammedov , =?UTF-8?q?Andreas=20F=C3=A4rber?= Add weak alias to vmstate stub functions on qdev.c, so that qdev.o can be used without savevm.o when vmstate support is not necessary (i.e. by *-user). Signed-off-by: Eduardo Habkost --- Originally submitted as: Subject: qdev-core: isolate vmstate handling into separate functions Changes v1 -> v2: - Add GCC_WEAK_DECL to function declarations Changes v2 -> v3: - Make vmstate_register_with_alias_id()/vmstate_unregister() have GCC_WEAK versions, instead of creating a new function - Kept qdev_get_vmsd() inside qdev.c Changess v3 -> v4: - Use the new QEMU_WEAK_ALIAS system instead of GCC_WEAK --- hw/qdev.c | 24 ++++++++++++++++++++++++ vmstate.h | 2 ++ 2 files changed, 26 insertions(+) diff --git a/hw/qdev.c b/hw/qdev.c index c242097..94ae1cd 100644 --- a/hw/qdev.c +++ b/hw/qdev.c @@ -76,6 +76,30 @@ void qemu_devices_reset(void) } } +/* vmstate register/unregister: + * + * The real implementations are on qdev-system.c and savevm.c. + * Those are weak symbols used by *-user. + */ + +static int stub_vmstate_register_with_alias_id(DeviceState *dev, + int instance_id, + const VMStateDescription *vmsd, + void *base, int alias_id, + int required_for_version) +{ + return 0; +} +QEMU_WEAK_ALIAS(vmstate_register_with_alias_id, + stub_vmstate_register_with_alias_id); + +static void stub_vmstate_unregister(DeviceState *dev, + const VMStateDescription *vmsd, + void *opaque) +{ +} +QEMU_WEAK_ALIAS(vmstate_unregister, stub_vmstate_unregister); + const VMStateDescription *qdev_get_vmsd(DeviceState *dev) { DeviceClass *dc = DEVICE_GET_CLASS(dev); diff --git a/vmstate.h b/vmstate.h index 623af0a..114c994 100644 --- a/vmstate.h +++ b/vmstate.h @@ -624,6 +624,8 @@ void vmstate_save_state(QEMUFile *f, const VMStateDescription *vmsd, void *opaque); int vmstate_register(DeviceState *dev, int instance_id, const VMStateDescription *vmsd, void *base); + +/* The following functions have weak aliases on qdev-core, for *-user: */ int vmstate_register_with_alias_id(DeviceState *dev, int instance_id, const VMStateDescription *vmsd, void *base, int alias_id, -- 1.7.11.7