* [Qemu-devel] [PATCH] coroutine-sigaltstack.c: Use stack_t, not struct sigaltstack
@ 2012-11-10 21:47 Peter Maydell
2012-11-12 12:57 ` Stefan Hajnoczi
0 siblings, 1 reply; 3+ messages in thread
From: Peter Maydell @ 2012-11-10 21:47 UTC (permalink / raw)
To: qemu-devel; +Cc: Alex Barcelo, patches
Use the POSIX-specified stack_t type as the argument to sigaltstack()
rather than the legacy struct sigaltstack. This allows us to compile
on MacOSX with --with-coroutine=sigaltstack.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
Tested on Linux and MacOSX.
coroutine-sigaltstack.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/coroutine-sigaltstack.c b/coroutine-sigaltstack.c
index 861e878..39dbaa5 100644
--- a/coroutine-sigaltstack.c
+++ b/coroutine-sigaltstack.c
@@ -171,8 +171,8 @@ static Coroutine *coroutine_new(void)
CoroutineThreadState *coTS;
struct sigaction sa;
struct sigaction osa;
- struct sigaltstack ss;
- struct sigaltstack oss;
+ stack_t ss;
+ stack_t oss;
sigset_t sigs;
sigset_t osigs;
jmp_buf old_env;
--
1.7.11.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] coroutine-sigaltstack.c: Use stack_t, not struct sigaltstack
2012-11-10 21:47 [Qemu-devel] [PATCH] coroutine-sigaltstack.c: Use stack_t, not struct sigaltstack Peter Maydell
@ 2012-11-12 12:57 ` Stefan Hajnoczi
2012-11-27 10:53 ` Kevin Wolf
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Hajnoczi @ 2012-11-12 12:57 UTC (permalink / raw)
To: Peter Maydell; +Cc: Alex Barcelo, qemu-devel, patches
On Sat, Nov 10, 2012 at 10:47 PM, Peter Maydell
<peter.maydell@linaro.org> wrote:
> Use the POSIX-specified stack_t type as the argument to sigaltstack()
> rather than the legacy struct sigaltstack. This allows us to compile
> on MacOSX with --with-coroutine=sigaltstack.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> Tested on Linux and MacOSX.
>
> coroutine-sigaltstack.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] coroutine-sigaltstack.c: Use stack_t, not struct sigaltstack
2012-11-12 12:57 ` Stefan Hajnoczi
@ 2012-11-27 10:53 ` Kevin Wolf
0 siblings, 0 replies; 3+ messages in thread
From: Kevin Wolf @ 2012-11-27 10:53 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: Peter Maydell, Alex Barcelo, qemu-devel, patches
Am 12.11.2012 13:57, schrieb Stefan Hajnoczi:
> On Sat, Nov 10, 2012 at 10:47 PM, Peter Maydell
> <peter.maydell@linaro.org> wrote:
>> Use the POSIX-specified stack_t type as the argument to sigaltstack()
>> rather than the legacy struct sigaltstack. This allows us to compile
>> on MacOSX with --with-coroutine=sigaltstack.
>>
>> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
>> ---
>> Tested on Linux and MacOSX.
>>
>> coroutine-sigaltstack.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Thanks, applied to the block branch for 1.3.
Kevin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-27 10:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-10 21:47 [Qemu-devel] [PATCH] coroutine-sigaltstack.c: Use stack_t, not struct sigaltstack Peter Maydell
2012-11-12 12:57 ` Stefan Hajnoczi
2012-11-27 10:53 ` Kevin Wolf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).