From: Evgeny Voevodin <e.voevodin@samsung.com>
To: qemu-devel@nongnu.org
Cc: Evgeny Voevodin <e.voevodin@samsung.com>,
blauwirbel@gmail.com, kyungmin.park@samsung.com,
edgar.iglesias@gmail.com, aurelien@aurel32.net, rth@twiddle.net
Subject: [Qemu-devel] [PATCH v6 6/7] TCG: Use gen_opparam_buf from context instead of global variable.
Date: Mon, 12 Nov 2012 13:27:48 +0400 [thread overview]
Message-ID: <1352712469-27974-7-git-send-email-e.voevodin@samsung.com> (raw)
In-Reply-To: <1352712469-27974-1-git-send-email-e.voevodin@samsung.com>
Signed-off-by: Evgeny Voevodin <e.voevodin@samsung.com>
Reviewed-by: Richard Henderson <rth@twiddle.net>
---
tcg/tcg.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/tcg/tcg.c b/tcg/tcg.c
index a039001..ea0bd3a 100644
--- a/tcg/tcg.c
+++ b/tcg/tcg.c
@@ -298,7 +298,7 @@ void tcg_func_start(TCGContext *s)
#endif
s->gen_opc_ptr = s->gen_opc_buf;
- s->gen_opparam_ptr = gen_opparam_buf;
+ s->gen_opparam_ptr = s->gen_opparam_buf;
#if defined(CONFIG_QEMU_LDST_OPTIMIZATION) && defined(CONFIG_SOFTMMU)
/* Initialize qemu_ld/st labels to assist code generation at the end of TB
@@ -897,7 +897,7 @@ void tcg_dump_ops(TCGContext *s)
first_insn = 1;
opc_ptr = s->gen_opc_buf;
- args = gen_opparam_buf;
+ args = s->gen_opparam_buf;
while (opc_ptr < s->gen_opc_ptr) {
c = *opc_ptr++;
def = &tcg_op_defs[c];
@@ -1440,8 +1440,9 @@ static void tcg_liveness_analysis(TCGContext *s)
op_index--;
}
- if (args != gen_opparam_buf)
+ if (args != s->gen_opparam_buf) {
tcg_abort();
+ }
}
#else
/* dummy liveness analysis */
@@ -2222,7 +2223,7 @@ static inline int tcg_gen_code_common(TCGContext *s, uint8_t *gen_code_buf,
#ifdef USE_TCG_OPTIMIZATIONS
s->gen_opparam_ptr =
- tcg_optimize(s, s->gen_opc_ptr, gen_opparam_buf, tcg_op_defs);
+ tcg_optimize(s, s->gen_opc_ptr, s->gen_opparam_buf, tcg_op_defs);
#endif
#ifdef CONFIG_PROFILER
@@ -2249,7 +2250,7 @@ static inline int tcg_gen_code_common(TCGContext *s, uint8_t *gen_code_buf,
s->code_buf = gen_code_buf;
s->code_ptr = gen_code_buf;
- args = gen_opparam_buf;
+ args = s->gen_opparam_buf;
op_index = 0;
for(;;) {
--
1.7.9.5
next prev parent reply other threads:[~2012-11-12 9:28 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 9:27 [Qemu-devel] [PATCH v6 0/7] TCG global variables clean-up Evgeny Voevodin
2012-11-12 9:27 ` [Qemu-devel] [PATCH v6 1/7] target-cris/translate.c: Code style clean-up Evgeny Voevodin
2012-11-12 9:27 ` [Qemu-devel] [PATCH v6 2/7] tcg/tcg.h: Duplicate global TCG variables in TCGContext Evgeny Voevodin
2012-11-12 9:27 ` [Qemu-devel] [PATCH v6 3/7] TCG: Use gen_opc_ptr from context instead of global variable Evgeny Voevodin
2012-11-12 9:27 ` [Qemu-devel] [PATCH v6 4/7] TCG: Use gen_opparam_ptr " Evgeny Voevodin
2012-11-12 9:27 ` [Qemu-devel] [PATCH v6 5/7] TCG: Use gen_opc_buf " Evgeny Voevodin
2012-11-12 9:27 ` Evgeny Voevodin [this message]
2012-11-12 9:27 ` [Qemu-devel] [PATCH v6 7/7] TCG: Remove unused global variables Evgeny Voevodin
2012-11-16 4:00 ` [Qemu-devel] [PATCH v6 0/7] TCG global variables clean-up Evgeny Voevodin
2012-11-17 18:14 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352712469-27974-7-git-send-email-e.voevodin@samsung.com \
--to=e.voevodin@samsung.com \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=edgar.iglesias@gmail.com \
--cc=kyungmin.park@samsung.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).