From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com
Subject: [Qemu-devel] [PATCH 4/7] nbd: fix nbd_server_stop crash when no server was running
Date: Mon, 12 Nov 2012 15:22:04 +0100 [thread overview]
Message-ID: <1352730127-32685-5-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1352730127-32685-1-git-send-email-pbonzini@redhat.com>
This failed on the new assertion of qemu_set_fd_handler2:
qemu-system-x86_64: /home/pbonzini/work/upstream/qemu/iohandler.c:60: qemu_set_fd_handler2: Assertion `fd >= 0' failed.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
blockdev-nbd.c | 8 +++++---
1 file modificato, 5 inserzioni(+), 3 rimozioni(-)
diff --git a/blockdev-nbd.c b/blockdev-nbd.c
index 8031813..274fba6 100644
--- a/blockdev-nbd.c
+++ b/blockdev-nbd.c
@@ -113,7 +113,9 @@ void qmp_nbd_server_stop(Error **errp)
nbd_close_notifier(&cn->n, nbd_export_get_blockdev(cn->exp));
}
- qemu_set_fd_handler2(server_fd, NULL, NULL, NULL, NULL);
- close(server_fd);
- server_fd = -1;
+ if (server_fd != -1) {
+ qemu_set_fd_handler2(server_fd, NULL, NULL, NULL, NULL);
+ close(server_fd);
+ server_fd = -1;
+ }
}
--
1.7.12.1
next prev parent reply other threads:[~2012-11-12 14:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-12 14:22 [Qemu-devel] [PULL 1.3 0/7] NBD updates for 2012-11-12 Paolo Bonzini
2012-11-12 14:22 ` [Qemu-devel] [PATCH 1/7] qemu-nbd: initialize main loop before block layer Paolo Bonzini
2012-11-12 14:22 ` [Qemu-devel] [PATCH 2/7] nbd: accept relative path to Unix socket Paolo Bonzini
2012-11-12 14:22 ` [Qemu-devel] [PATCH 3/7] nbd: accept URIs Paolo Bonzini
2012-11-12 14:22 ` Paolo Bonzini [this message]
2012-11-12 14:22 ` [Qemu-devel] [PATCH 5/7] nbd: force read-only export for read-only devices Paolo Bonzini
2012-11-12 14:22 ` [Qemu-devel] [PATCH 6/7] nbd: disallow nbd-server-add before nbd-server-start Paolo Bonzini
2012-11-12 14:22 ` [Qemu-devel] [PATCH 7/7] hmp: add NBD server commands Paolo Bonzini
2012-11-13 10:20 ` [Qemu-devel] [PULL 1.3 0/7] NBD updates for 2012-11-12 Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352730127-32685-5-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).