From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51154) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TXuuP-0004kO-Hl for qemu-devel@nongnu.org; Mon, 12 Nov 2012 09:22:44 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TXuuM-0003ol-Dc for qemu-devel@nongnu.org; Mon, 12 Nov 2012 09:22:41 -0500 Received: from mail-pa0-f45.google.com ([209.85.220.45]:64449) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TXuuM-0003mX-7H for qemu-devel@nongnu.org; Mon, 12 Nov 2012 09:22:38 -0500 Received: by mail-pa0-f45.google.com with SMTP id fb10so4204030pad.4 for ; Mon, 12 Nov 2012 06:22:37 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Mon, 12 Nov 2012 15:22:05 +0100 Message-Id: <1352730127-32685-6-git-send-email-pbonzini@redhat.com> In-Reply-To: <1352730127-32685-1-git-send-email-pbonzini@redhat.com> References: <1352730127-32685-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 5/7] nbd: force read-only export for read-only devices List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com This is the desired behavior for HMP, but it is a better choice for QMP as well. Signed-off-by: Paolo Bonzini --- blockdev-nbd.c | 7 +++++++ 1 file modificato, 7 inserzioni(+) diff --git a/blockdev-nbd.c b/blockdev-nbd.c index 274fba6..e362572 100644 --- a/blockdev-nbd.c +++ b/blockdev-nbd.c @@ -93,6 +93,13 @@ void qmp_nbd_server_add(const char *device, bool has_writable, bool writable, return; } + if (!has_writable) { + writable = true; + } + if (bdrv_is_read_only(bs)) { + writable = false; + } + exp = nbd_export_new(bs, 0, -1, writable ? 0 : NBD_FLAG_READ_ONLY, nbd_server_put_ref); -- 1.7.12.1