qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: agraf@suse.de
Cc: Michael Ellerman <michael@ellerman.id.au>,
	qemu-ppc@nongnu.org, qemu-devel@nongnu.org,
	David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PATCH 04/12] pseries: Return the token when we register an RTAS call
Date: Tue, 13 Nov 2012 13:46:52 +1100	[thread overview]
Message-ID: <1352774820-22804-5-git-send-email-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <1352774820-22804-1-git-send-email-david@gibson.dropbear.id.au>

From: Michael Ellerman <michael@ellerman.id.au>

The kernel will soon be able to service some RTAS calls. However the
choice of tokens will still be up to userspace. To support this have
spapr_rtas_register() return the token that is allocated for an
RTAS call, that allows the calling code to tell the kernel what the
token value is.

Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 hw/spapr.h      |    2 +-
 hw/spapr_rtas.c |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/hw/spapr.h b/hw/spapr.h
index efe7f57..971a50a 100644
--- a/hw/spapr.h
+++ b/hw/spapr.h
@@ -320,7 +320,7 @@ static inline void rtas_st(target_ulong phys, int n, uint32_t val)
 typedef void (*spapr_rtas_fn)(sPAPREnvironment *spapr, uint32_t token,
                               uint32_t nargs, target_ulong args,
                               uint32_t nret, target_ulong rets);
-void spapr_rtas_register(const char *name, spapr_rtas_fn fn);
+int spapr_rtas_register(const char *name, spapr_rtas_fn fn);
 target_ulong spapr_rtas_call(sPAPREnvironment *spapr,
                              uint32_t token, uint32_t nargs, target_ulong args,
                              uint32_t nret, target_ulong rets);
diff --git a/hw/spapr_rtas.c b/hw/spapr_rtas.c
index 6d5c48a..45294e8 100644
--- a/hw/spapr_rtas.c
+++ b/hw/spapr_rtas.c
@@ -242,7 +242,7 @@ target_ulong spapr_rtas_call(sPAPREnvironment *spapr,
     return H_PARAMETER;
 }
 
-void spapr_rtas_register(const char *name, spapr_rtas_fn fn)
+int spapr_rtas_register(const char *name, spapr_rtas_fn fn)
 {
     int i;
 
@@ -258,7 +258,7 @@ void spapr_rtas_register(const char *name, spapr_rtas_fn fn)
     rtas_next->name = name;
     rtas_next->fn = fn;
 
-    rtas_next++;
+    return (rtas_next++ - rtas_table) + TOKEN_BASE;
 }
 
 int spapr_rtas_device_tree_setup(void *fdt, hwaddr rtas_addr,
-- 
1.7.10.4

  parent reply	other threads:[~2012-11-13  2:45 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-13  2:46 [Qemu-devel] [0/12] Pending pseries patches David Gibson
2012-11-13  2:46 ` [Qemu-devel] [PATCH 01/12] pseries: Fix incorrect initialization of interrupt controller David Gibson
2012-11-13  2:46 ` [Qemu-devel] [PATCH 02/12] pseries: Use #define for XICS base irq number David Gibson
2012-11-13  2:46 ` [Qemu-devel] [PATCH 03/12] pseries: Move XICS initialization before cpu initialization David Gibson
2012-11-19 16:22   ` Alexander Graf
2012-11-19 19:54     ` Benjamin Herrenschmidt
2012-11-19 22:47       ` [Qemu-devel] [Qemu-ppc] " David Gibson
2012-11-20  9:26         ` Alexander Graf
2012-11-21  1:10           ` David Gibson
2012-11-13  2:46 ` David Gibson [this message]
2012-11-13  2:46 ` [Qemu-devel] [PATCH 05/12] pseries: Allow RTAS tokens without a qemu handler David Gibson
2012-11-13  2:46 ` [Qemu-devel] [PATCH 06/12] pseries: Add tracepoints to the XICS interrupt controller David Gibson
2012-11-13  2:46 ` [Qemu-devel] [PATCH 07/12] pseries: Split xics irq configuration from state information David Gibson
2012-11-13  2:46 ` [Qemu-devel] [PATCH 08/12] target-ppc: Convert ppcemb_tlb_t to use fixed 64-bit RPN David Gibson
2012-11-19 16:26   ` Alexander Graf
2012-11-19 22:48     ` [Qemu-devel] [Qemu-ppc] " David Gibson
2012-11-20  9:29       ` Alexander Graf
2012-11-20  9:53         ` Peter Maydell
2012-11-20  9:55           ` Alexander Graf
2012-11-21  1:14             ` David Gibson
2012-11-21  1:48               ` Alexander Graf
2012-11-21  1:56                 ` David Gibson
2012-11-21 10:07                   ` Alexander Graf
2012-11-13  2:46 ` [Qemu-devel] [PATCH 09/12] pseries: Implement PAPR NVRAM David Gibson
2012-11-13  2:46 ` [Qemu-devel] [PATCH 10/12] pseries: Update SLOF for NVRAM support David Gibson
2012-11-13  2:46 ` [Qemu-devel] [PATCH 11/12] pseries: Fix bug in PCI MSI allocation David Gibson
2012-11-13  2:47 ` [Qemu-devel] [PATCH 12/12] pseries: Generate unique LIOBNs for PCI host bridges David Gibson
2012-11-19 16:34   ` Alexander Graf
2012-11-19 22:51     ` [Qemu-devel] [Qemu-ppc] " David Gibson
2012-11-20  9:27       ` Alexander Graf
2012-11-20 12:26         ` Michael S. Tsirkin
2012-11-21  0:57           ` David Gibson
2012-11-21 11:34             ` Michael S. Tsirkin
2012-11-21 12:36               ` David Gibson
2012-11-21 13:13                 ` Michael S. Tsirkin
2012-11-21 13:21                   ` David Gibson
2012-11-21 13:27                     ` Alexander Graf
2012-11-21 15:27                       ` Michael S. Tsirkin
2012-11-22  2:27                         ` David Gibson
2012-11-22  7:23                           ` Michael S. Tsirkin
2012-11-22 11:27                             ` Alexander Graf
2012-11-22 11:39                               ` Michael S. Tsirkin
2012-11-23  4:13                             ` David Gibson
2012-11-23 10:53                               ` Michael S. Tsirkin
2012-11-23 12:59                                 ` David Gibson
2012-11-23 13:44                                   ` Michael S. Tsirkin
2012-11-23 13:44                                     ` Alexander Graf
2012-11-23 14:01                                       ` Michael S. Tsirkin
2012-11-23 14:03                                         ` Alexander Graf
2012-11-23 14:18                                           ` Michael S. Tsirkin
2012-11-23 14:27                                             ` Alexander Graf
2012-11-25 23:24                                         ` David Gibson
2012-11-21 15:20                     ` Michael S. Tsirkin
2012-11-21  5:00         ` David Gibson
2012-11-21 10:09           ` Alexander Graf
2012-11-21 11:40             ` Michael S. Tsirkin
2012-11-19 16:35 ` [Qemu-devel] [0/12] Pending pseries patches Alexander Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1352774820-22804-5-git-send-email-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=agraf@suse.de \
    --cc=michael@ellerman.id.au \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).