qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Christian Borntraeger <borntraeger@de.ibm.com>
To: kwolf@redhat.com, stefanha@gmail.com
Cc: aliguori@us.ibm.com, qemu-devel@nongnu.org, agraf@suse.de,
	borntraeger@de.ibm.com, jfrei@linux.vnet.ibm.com,
	cornelia.huck@de.ibm.com, pbonzini@redhat.com,
	Einar Lueck <elelueck@linux.vnet.ibm.com>,
	Einar Lueck <elelueck@de.ibm.com>
Subject: [Qemu-devel] [PATCH 2/3] hd-geometry.c/s390: Disable geometry translation
Date: Tue, 13 Nov 2012 09:50:11 +0100	[thread overview]
Message-ID: <1352796612-49081-3-git-send-email-borntraeger@de.ibm.com> (raw)
In-Reply-To: <1352796612-49081-1-git-send-email-borntraeger@de.ibm.com>

From: Einar Lueck <elelueck@linux.vnet.ibm.com>

This patch disables the translation of geometry information read from
disks on s390. On s390 such translations lead to wrong geometries being
advertized to the guest because there is no entity doing these kinds
of translation on this architecture.

Signed-off-by Einar Lueck <elelueck@linux.vnet.ibm.com>
Signed-off-by Christian Borntraeger <borntraeger@de.ibm.com>
---
 hw/hd-geometry.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/hw/hd-geometry.c b/hw/hd-geometry.c
index 4cf040d..db1dc81 100644
--- a/hw/hd-geometry.c
+++ b/hw/hd-geometry.c
@@ -144,6 +144,10 @@ static int guess_disk_msdosgeo(BlockDriverState *bs,
                 continue;
             }
 
+#ifdef __s390__
+            /* on s390 there is no BIOS doing any kind of translation */
+            translation = BIOS_ATA_TRANSLATION_NONE;
+#else
             if (heads > 16) {
                 /* LCHS guess with heads > 16 means that a BIOS LBA
                    translation was active, so a standard physical disk
@@ -158,6 +162,7 @@ static int guess_disk_msdosgeo(BlockDriverState *bs,
                    the logical geometry */
                 translation = BIOS_ATA_TRANSLATION_NONE;
             }
+#endif
             *pheads = heads;
             *psectors = sectors;
             *pcylinders = cylinders;
-- 
1.7.10.1

  parent reply	other threads:[~2012-11-13  8:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-13  8:50 [Qemu-devel] [PATCH 0/3] block patches for auto detection of geometry and block size Christian Borntraeger
2012-11-13  8:50 ` [Qemu-devel] [PATCH 1/3] hd-geometry.c: Integrate HDIO_GETGEO in guessing Christian Borntraeger
2012-11-19 15:08   ` Markus Armbruster
2012-11-19 15:30     ` Christian Borntraeger
2012-11-13  8:50 ` Christian Borntraeger [this message]
2012-11-17 16:07   ` [Qemu-devel] [PATCH 2/3] hd-geometry.c/s390: Disable geometry translation Blue Swirl
2012-11-18 16:10     ` Paolo Bonzini
2012-11-18 19:14       ` Blue Swirl
2012-11-19 10:59         ` Christian Borntraeger
2012-11-19 11:20           ` Alexander Graf
2012-11-13  8:50 ` [Qemu-devel] [PATCH 3/3] block: support auto-sensing of block sizes Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1352796612-49081-3-git-send-email-borntraeger@de.ibm.com \
    --to=borntraeger@de.ibm.com \
    --cc=agraf@suse.de \
    --cc=aliguori@us.ibm.com \
    --cc=cornelia.huck@de.ibm.com \
    --cc=elelueck@de.ibm.com \
    --cc=elelueck@linux.vnet.ibm.com \
    --cc=jfrei@linux.vnet.ibm.com \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).