From: Christian Borntraeger <borntraeger@de.ibm.com>
To: agraf@suse.de
Cc: Christian Borntraeger <borntraeger@de.ibm.com>,
Heinz Graalfs <graalfs@linux.vnet.ibm.com>,
qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 06/24] Remove local ram_size that hides global one
Date: Tue, 13 Nov 2012 13:11:49 +0100 [thread overview]
Message-ID: <1352808709-11215-1-git-send-email-borntraeger@de.ibm.com> (raw)
From: Heinz Graalfs <graalfs@linux.vnet.ibm.com>
The global variable 'ram_size' is hidden by the local variable
declaration in s390_init()
Signed-off-by: Heinz Graalfs <graalfs@linux.vnet.ibm.com>
Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
---
hw/s390-virtio.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/s390-virtio.c b/hw/s390-virtio.c
index ebec844..78477af 100644
--- a/hw/s390-virtio.c
+++ b/hw/s390-virtio.c
@@ -155,7 +155,6 @@ unsigned s390_del_running_cpu(CPUS390XState *env)
static void s390_init(QEMUMachineInitArgs *args)
{
ram_addr_t my_ram_size = args->ram_size;
- ram_addr_t ram_size = args->ram_size;
const char *cpu_model = args->cpu_model;
const char *kernel_filename = args->kernel_filename;
const char *kernel_cmdline = args->kernel_cmdline;
--
1.7.10.1
next reply other threads:[~2012-11-13 12:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 12:11 Christian Borntraeger [this message]
2012-11-19 13:14 ` [Qemu-devel] [PATCH 06/24] Remove local ram_size that hides global one Alexander Graf
2012-11-19 13:20 ` Peter Maydell
2012-11-19 13:35 ` Eduardo Habkost
2012-11-19 13:46 ` Alexander Graf
2012-11-20 9:28 ` [Qemu-devel] [PATCH 1/1] s390: Fix ram_size updating in machine init Christian Borntraeger
2012-11-20 9:31 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352808709-11215-1-git-send-email-borntraeger@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=agraf@suse.de \
--cc=graalfs@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).