From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, pbonzini@redhat.com
Subject: [Qemu-devel] [PATCH 2/4] megasas: Use bdrv_drain_all instead of qemu_aio_flush
Date: Tue, 13 Nov 2012 16:51:27 +0100 [thread overview]
Message-ID: <1352821889-24150-3-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1352821889-24150-1-git-send-email-kwolf@redhat.com>
Calling qemu_aio_flush() directly can hang when combined with I/O
throttling.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
hw/megasas.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/megasas.c b/hw/megasas.c
index 7a2036e..d332d41 100644
--- a/hw/megasas.c
+++ b/hw/megasas.c
@@ -1296,7 +1296,7 @@ static int megasas_dcmd_get_properties(MegasasState *s, MegasasCmd *cmd)
static int megasas_cache_flush(MegasasState *s, MegasasCmd *cmd)
{
- qemu_aio_flush();
+ bdrv_drain_all();
return MFI_STAT_OK;
}
--
1.7.6.5
next prev parent reply other threads:[~2012-11-13 15:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-13 15:51 [Qemu-devel] [PATCH 0/4] Fix qemu_aio_flush callers Kevin Wolf
2012-11-13 15:51 ` [Qemu-devel] [RFC PATCH 1/4] block: Improve bdrv_aio_co_cancel_em Kevin Wolf
2012-11-13 15:51 ` Kevin Wolf [this message]
2012-11-13 15:51 ` [Qemu-devel] [PATCH 3/4] qemu-io: Use bdrv_drain_all instead of qemu_aio_flush Kevin Wolf
2012-11-13 15:51 ` [Qemu-devel] [RFC PATCH 4/4] aio: Get rid of qemu_aio_flush() Kevin Wolf
2012-11-13 17:39 ` [Qemu-devel] [PATCH 0/4] Fix qemu_aio_flush callers Paolo Bonzini
2012-11-14 7:29 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352821889-24150-3-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).