From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49568) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYIm9-00044R-1g for qemu-devel@nongnu.org; Tue, 13 Nov 2012 10:51:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TYIm5-0006m7-VQ for qemu-devel@nongnu.org; Tue, 13 Nov 2012 10:51:44 -0500 Received: from mx1.redhat.com ([209.132.183.28]:35649) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYIm5-0006lw-Nh for qemu-devel@nongnu.org; Tue, 13 Nov 2012 10:51:41 -0500 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qADFpeNX009695 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 13 Nov 2012 10:51:41 -0500 From: Kevin Wolf Date: Tue, 13 Nov 2012 16:51:27 +0100 Message-Id: <1352821889-24150-3-git-send-email-kwolf@redhat.com> In-Reply-To: <1352821889-24150-1-git-send-email-kwolf@redhat.com> References: <1352821889-24150-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 2/4] megasas: Use bdrv_drain_all instead of qemu_aio_flush List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, pbonzini@redhat.com Calling qemu_aio_flush() directly can hang when combined with I/O throttling. Signed-off-by: Kevin Wolf --- hw/megasas.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/hw/megasas.c b/hw/megasas.c index 7a2036e..d332d41 100644 --- a/hw/megasas.c +++ b/hw/megasas.c @@ -1296,7 +1296,7 @@ static int megasas_dcmd_get_properties(MegasasState *s, MegasasCmd *cmd) static int megasas_cache_flush(MegasasState *s, MegasasCmd *cmd) { - qemu_aio_flush(); + bdrv_drain_all(); return MFI_STAT_OK; } -- 1.7.6.5