From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:59898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYhzz-0007w0-Hr for qemu-devel@nongnu.org; Wed, 14 Nov 2012 13:47:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TYhzw-0000Rs-EC for qemu-devel@nongnu.org; Wed, 14 Nov 2012 13:47:43 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34754) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TYhzw-0000Ro-6V for qemu-devel@nongnu.org; Wed, 14 Nov 2012 13:47:40 -0500 From: Kevin Wolf Date: Wed, 14 Nov 2012 19:47:06 +0100 Message-Id: <1352918847-3696-6-git-send-email-kwolf@redhat.com> In-Reply-To: <1352918847-3696-1-git-send-email-kwolf@redhat.com> References: <1352918847-3696-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH 05/26] block: Workaround for older versions of MinGW gcc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: anthony@codemonkey.ws Cc: kwolf@redhat.com, qemu-devel@nongnu.org From: Stefan Weil Versions before gcc-4.6 don't support unnamed fields in initializers (see http://gcc.gnu.org/bugzilla/show_bug.cgi?id=10676). Offset and OffsetHigh belong to an unnamed struct which is part of an unnamed union. Therefore the original code does not work with older versions of gcc. Signed-off-by: Stefan Weil Reviewed-by: Stefan Hajnoczi Signed-off-by: Kevin Wolf --- block/win32-aio.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/block/win32-aio.c b/block/win32-aio.c index c34dc73..92f25a9 100644 --- a/block/win32-aio.c +++ b/block/win32-aio.c @@ -167,11 +167,11 @@ BlockDriverAIOCB *win32_aio_submit(BlockDriverState *bs, waiocb->is_linear = true; } - waiocb->ov = (OVERLAPPED) { - .Offset = (DWORD) offset, - .OffsetHigh = (DWORD) (offset >> 32), - .hEvent = event_notifier_get_handle(&aio->e) - }; + memset(&waiocb->ov, 0, sizeof(waiocb->ov)); + waiocb->ov.Offset = (DWORD)offset; + waiocb->ov.OffsetHigh = (DWORD)(offset >> 32); + waiocb->ov.hEvent = event_notifier_get_handle(&aio->e); + aio->count++; if (type & QEMU_AIO_READ) { -- 1.7.6.5