* [Qemu-devel] [PATCH] sd: Send debug printfery to stderr not stdout
@ 2012-11-15 6:32 Peter Crosthwaite
2012-11-15 8:52 ` Peter Maydell
2012-11-16 13:53 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
0 siblings, 2 replies; 3+ messages in thread
From: Peter Crosthwaite @ 2012-11-15 6:32 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Peter Crosthwaite
Some debug printfs for SD are coming up in stdout. Redirected them to stderr
instead.
Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
---
hw/sd.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/sd.c b/hw/sd.c
index 3c34d43..607edba 100644
--- a/hw/sd.c
+++ b/hw/sd.c
@@ -1439,8 +1439,8 @@ send_response:
int i;
DPRINTF("Response:");
for (i = 0; i < rsplen; i++)
- printf(" %02x", response[i]);
- printf(" state %d\n", sd->state);
+ fprintf(stderr, " %02x", response[i]);
+ fprintf(stderr, " state %d\n", sd->state);
} else {
DPRINTF("No response %d\n", sd->state);
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] sd: Send debug printfery to stderr not stdout
2012-11-15 6:32 [Qemu-devel] [PATCH] sd: Send debug printfery to stderr not stdout Peter Crosthwaite
@ 2012-11-15 8:52 ` Peter Maydell
2012-11-16 13:53 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2012-11-15 8:52 UTC (permalink / raw)
To: Peter Crosthwaite; +Cc: qemu-trivial, qemu-devel
On 15 November 2012 06:32, Peter Crosthwaite
<peter.crosthwaite@xilinx.com> wrote:
> Some debug printfs for SD are coming up in stdout. Redirected them to stderr
> instead.
>
> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
(the patched section is inside an #ifdef DEBUG_SD guard, so
it's ok to be doing fprintf()s here.)
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] sd: Send debug printfery to stderr not stdout
2012-11-15 6:32 [Qemu-devel] [PATCH] sd: Send debug printfery to stderr not stdout Peter Crosthwaite
2012-11-15 8:52 ` Peter Maydell
@ 2012-11-16 13:53 ` Stefan Hajnoczi
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2012-11-16 13:53 UTC (permalink / raw)
To: Peter Crosthwaite; +Cc: qemu-trivial, qemu-devel
On Thu, Nov 15, 2012 at 04:32:53PM +1000, Peter Crosthwaite wrote:
> Some debug printfs for SD are coming up in stdout. Redirected them to stderr
> instead.
>
> Signed-off-by: Peter Crosthwaite <peter.crosthwaite@xilinx.com>
> ---
> hw/sd.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-11-16 13:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-15 6:32 [Qemu-devel] [PATCH] sd: Send debug printfery to stderr not stdout Peter Crosthwaite
2012-11-15 8:52 ` Peter Maydell
2012-11-16 13:53 ` [Qemu-devel] [Qemu-trivial] " Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).