From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZMas-00013G-5p for qemu-devel@nongnu.org; Fri, 16 Nov 2012 09:08:33 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TZMap-0007x1-3k for qemu-devel@nongnu.org; Fri, 16 Nov 2012 09:08:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43543) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TZMao-0007ws-SW for qemu-devel@nongnu.org; Fri, 16 Nov 2012 09:08:27 -0500 From: Stefan Hajnoczi Date: Fri, 16 Nov 2012 15:08:14 +0100 Message-Id: <1353074895-3712-2-git-send-email-stefanha@redhat.com> In-Reply-To: <1353074895-3712-1-git-send-email-stefanha@redhat.com> References: <1353074895-3712-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH 1/2] qemu-sockets: Fix parsing of the inet option 'to'. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Anthony PERARD , Stefan Hajnoczi From: Anthony PERARD Having a qemu command line argument like "-vnc 127.0.0.1:0,to=99" is broken. This have been break with commit 879e45c72da1569e07fbbc6a1aa2a708ea796044. Signed-off-by: Anthony PERARD Signed-off-by: Stefan Hajnoczi --- qemu-sockets.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/qemu-sockets.c b/qemu-sockets.c index abcd791..03ca98d 100644 --- a/qemu-sockets.c +++ b/qemu-sockets.c @@ -551,8 +551,9 @@ static InetSocketAddress *inet_parse(const char *str, Error **errp) optstr = str + pos; h = strstr(optstr, ",to="); if (h) { - if (1 != sscanf(str, "%d%n", &to, &pos) || - (str[pos] != '\0' && str[pos] != ',')) { + h += 4; + if (sscanf(h, "%d%n", &to, &pos) != 1 || + (h[pos] != '\0' && h[pos] != ',')) { error_setg(errp, "error parsing to= argument"); goto fail; } -- 1.8.0