From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60898) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ta0Cr-0008Cd-Mr for qemu-devel@nongnu.org; Sun, 18 Nov 2012 03:26:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ta0Co-0000Ls-KD for qemu-devel@nongnu.org; Sun, 18 Nov 2012 03:26:21 -0500 From: Stefan Weil Date: Sun, 18 Nov 2012 09:26:15 +0100 Message-Id: <1353227175-24596-1-git-send-email-sw@weilnetz.de> Subject: [Qemu-devel] [PATCH] block: Fix regression for MinGW (assertion caused by short string) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-trivial@nongnu.org Cc: Kevin Wolf , Jim Meyering , qemu-devel@nongnu.org, Stefan Weil The local string tmp_filename is passed to function get_tmp_filename which expects a string with minimum size MAX_PATH for w32 hosts. MAX_PATH is 260 and PATH_MAX is 259, so tmp_filename was too short. Commit eba25057b9a5e19d10ace2bc7716667a31297169 introduced this regression. Signed-off-by: Stefan Weil --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index 49dd6bb..8739635 100644 --- a/block.c +++ b/block.c @@ -787,7 +787,7 @@ int bdrv_open(BlockDriverState *bs, const char *filename, int flags, BlockDriver *drv) { int ret; - char tmp_filename[PATH_MAX]; + char tmp_filename[PATH_MAX + 1]; if (flags & BDRV_O_SNAPSHOT) { BlockDriverState *bs1; -- 1.7.10.4