* [Qemu-devel] [PATCH] tci: Fix build breakage (unresolved symbol tcg_out_tb_finalize)
@ 2012-11-18 19:16 Stefan Weil
2012-11-18 21:10 ` Blue Swirl
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Weil @ 2012-11-18 19:16 UTC (permalink / raw)
To: Blue Swirl; +Cc: Stefan Weil, qemu-devel
Commit 32761257c0b9fa7ee04d2871a6e48a41f119c469 enabled
qemu_ld/st optimization unconditionally for some hosts.
The TCG interpreter still does not support this kind of
optimization. Therefore builds with TCI fail with an
unresolved symbol tcg_out_tb_finalize. This is fixed here.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
configure | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index 19775bc..7cf990c 100755
--- a/configure
+++ b/configure
@@ -3908,7 +3908,10 @@ upper() {
case "$cpu" in
i386|x86_64|ppc)
- echo "CONFIG_QEMU_LDST_OPTIMIZATION=y" >> $config_target_mak
+ # The TCG interpreter currently does not support ld/st optimization.
+ if test "$tcg_interpreter" = "no" ; then
+ echo "CONFIG_QEMU_LDST_OPTIMIZATION=y" >> $config_target_mak
+ fi
;;
esac
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] tci: Fix build breakage (unresolved symbol tcg_out_tb_finalize)
2012-11-18 19:16 [Qemu-devel] [PATCH] tci: Fix build breakage (unresolved symbol tcg_out_tb_finalize) Stefan Weil
@ 2012-11-18 21:10 ` Blue Swirl
0 siblings, 0 replies; 2+ messages in thread
From: Blue Swirl @ 2012-11-18 21:10 UTC (permalink / raw)
To: Stefan Weil; +Cc: qemu-devel
Thanks, applied.
On Sun, Nov 18, 2012 at 7:16 PM, Stefan Weil <sw@weilnetz.de> wrote:
> Commit 32761257c0b9fa7ee04d2871a6e48a41f119c469 enabled
> qemu_ld/st optimization unconditionally for some hosts.
>
> The TCG interpreter still does not support this kind of
> optimization. Therefore builds with TCI fail with an
> unresolved symbol tcg_out_tb_finalize. This is fixed here.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
> ---
> configure | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 19775bc..7cf990c 100755
> --- a/configure
> +++ b/configure
> @@ -3908,7 +3908,10 @@ upper() {
>
> case "$cpu" in
> i386|x86_64|ppc)
> - echo "CONFIG_QEMU_LDST_OPTIMIZATION=y" >> $config_target_mak
> + # The TCG interpreter currently does not support ld/st optimization.
> + if test "$tcg_interpreter" = "no" ; then
> + echo "CONFIG_QEMU_LDST_OPTIMIZATION=y" >> $config_target_mak
> + fi
> ;;
> esac
>
> --
> 1.7.10.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-18 21:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-18 19:16 [Qemu-devel] [PATCH] tci: Fix build breakage (unresolved symbol tcg_out_tb_finalize) Stefan Weil
2012-11-18 21:10 ` Blue Swirl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).