qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: quintela@redhat.com
Subject: [Qemu-devel] [PATCH v2 1/4] buffered_file: reset bytes_xfer on every tick
Date: Tue, 20 Nov 2012 17:45:33 +0100	[thread overview]
Message-ID: <1353429936-29180-2-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1353429936-29180-1-git-send-email-pbonzini@redhat.com>

Even if the socket cannot send more data right now, whenever a new
tick has started we can send xfer_limit more bytes.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 buffered_file.c |    3 +--
 1 files changed, 1 insertions(+), 2 deletions(-)

diff --git a/buffered_file.c b/buffered_file.c
index bd0f61d..49e9089 100644
--- a/buffered_file.c
+++ b/buffered_file.c
@@ -233,11 +233,10 @@ static void buffered_rate_tick(void *opaque)
 
     qemu_mod_timer(s->timer, qemu_get_clock_ms(rt_clock) + 100);
 
+    s->bytes_xfer = 0;
     if (s->freeze_output)
         return;
 
-    s->bytes_xfer = 0;
-
     buffered_put_buffer(s, NULL, 0, 0);
 }
 
-- 
1.7.1

  reply	other threads:[~2012-11-20 16:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-20 16:45 [Qemu-devel] [PATCH v2 0/4] migration: fix rate limiting Paolo Bonzini
2012-11-20 16:45 ` Paolo Bonzini [this message]
2012-11-20 16:45 ` [Qemu-devel] [PATCH v2 2/4] buffered_file: do not send more than s->bytes_xfer bytes per tick Paolo Bonzini
2012-11-20 16:45 ` [Qemu-devel] [PATCH v2 3/4] buffered_file: rate-limit producers based on buffer size Paolo Bonzini
2012-11-24 19:53   ` Blue Swirl
2012-11-26  8:17     ` Paolo Bonzini
2012-11-20 16:45 ` [Qemu-devel] [PATCH v2 4/4] buffered_file: do not automatically unfreeze output on buffered_put_buffer Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353429936-29180-2-git-send-email-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).