qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Liu Ping Fan <qemulist@gmail.com>
To: qemu-devel@nongnu.org
Cc: Jan Kiszka <jan.kiszka@siemens.com>, Cam Macdonell <cam@cs.ualberta.ca>
Subject: [Qemu-devel] [PATCH] ivshmem: use irqfd to interrupt among VMs
Date: Wed, 21 Nov 2012 14:02:31 +0800	[thread overview]
Message-ID: <1353477751-9846-1-git-send-email-qemulist@gmail.com> (raw)

From: Liu Ping Fan <pingfank@linux.vnet.ibm.com>

Using irqfd, so we can avoid switch between kernel and user when
VMs interrupts each other.

Signed-off-by: Liu Ping Fan <pingfank@linux.vnet.ibm.com>
---
 hw/ivshmem.c |   48 +++++++++++++++++++++++++++++++++++++++++++++++-
 1 files changed, 47 insertions(+), 1 deletions(-)

diff --git a/hw/ivshmem.c b/hw/ivshmem.c
index f6dbb21..81c7354 100644
--- a/hw/ivshmem.c
+++ b/hw/ivshmem.c
@@ -19,6 +19,7 @@
 #include "hw.h"
 #include "pc.h"
 #include "pci.h"
+#include "msi.h"
 #include "msix.h"
 #include "kvm.h"
 #include "migration.h"
@@ -54,6 +55,11 @@ typedef struct EventfdEntry {
     int vector;
 } EventfdEntry;
 
+typedef struct IrqfdEntry {
+    int virq;
+    bool used;
+} IrqfdEntry;
+
 typedef struct IVShmemState {
     PCIDevice dev;
     uint32_t intrmask;
@@ -83,6 +89,8 @@ typedef struct IVShmemState {
     uint32_t vectors;
     uint32_t features;
     EventfdEntry *eventfd_table;
+    IrqfdEntry *vector_irqfd;
+    bool irqfd_enable;
 
     Error *migration_blocker;
 
@@ -632,6 +640,38 @@ static void ivshmem_write_config(PCIDevice *pci_dev, uint32_t address,
     msix_write_config(pci_dev, address, val, len);
 }
 
+static int ivshmem_vector_use(PCIDevice *dev, unsigned vector,
+                                     MSIMessage msg)
+{
+    IVShmemState *s = DO_UPCAST(IVShmemState, dev, dev);
+    int virq;
+    EventNotifier *n = &s->peers[s->vm_id].eventfds[vector];
+
+    virq = kvm_irqchip_add_msi_route(kvm_state, msg);
+    if (virq >= 0 && kvm_irqchip_add_irqfd_notifier(kvm_state, n, virq) >= 0) {
+        s->vector_irqfd[vector].virq = virq;
+        s->vector_irqfd[vector].used = true;
+        qemu_chr_add_handlers(s->eventfd_chr[vector], NULL, NULL, NULL, NULL);
+    } else if (virq >= 0) {
+        kvm_irqchip_release_virq(kvm_state, virq);
+    }
+    return 0;
+}
+
+static void ivshmem_vector_release(PCIDevice *dev, unsigned vector)
+{
+    IVShmemState *s = DO_UPCAST(IVShmemState, dev, dev);
+    EventNotifier *n = &s->peers[s->vm_id].eventfds[vector];
+    int virq = s->vector_irqfd[vector].virq;
+
+    if (s->vector_irqfd[vector].used) {
+        kvm_irqchip_remove_irqfd_notifier(kvm_state, n, virq);
+        kvm_irqchip_release_virq(kvm_state, virq);
+        s->vector_irqfd[vector].virq = -1;
+        s->vector_irqfd[vector].used = false;
+    }
+}
+
 static int pci_ivshmem_init(PCIDevice *dev)
 {
     IVShmemState *s = DO_UPCAST(IVShmemState, dev, dev);
@@ -759,7 +799,13 @@ static int pci_ivshmem_init(PCIDevice *dev)
     }
 
     s->dev.config_write = ivshmem_write_config;
-
+    if (kvm_gsi_routing_enabled()) {
+        s->irqfd_enable = msix_set_vector_notifiers(dev, ivshmem_vector_use,
+                    ivshmem_vector_release) >= 0 ? true : false;
+        if (s->irqfd_enable) {
+            s->vector_irqfd = g_new0(IrqfdEntry, s->vectors);
+        }
+    }
     return 0;
 }
 
-- 
1.7.4.4

             reply	other threads:[~2012-11-21  6:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-21  6:02 Liu Ping Fan [this message]
2012-11-21 12:43 ` [Qemu-devel] [PATCH] ivshmem: use irqfd to interrupt among VMs Jan Kiszka
2012-11-22  2:48   ` liu ping fan
2012-11-22 11:40     ` Jan Kiszka
2012-11-23  2:20       ` liu ping fan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353477751-9846-1-git-send-email-qemulist@gmail.com \
    --to=qemulist@gmail.com \
    --cc=cam@cs.ualberta.ca \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).