From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:34054) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tb7Th-0002cF-Ev for qemu-devel@nongnu.org; Wed, 21 Nov 2012 05:24:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tb7Td-0004Tn-AT for qemu-devel@nongnu.org; Wed, 21 Nov 2012 05:24:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:27190) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tb7Td-0004St-2J for qemu-devel@nongnu.org; Wed, 21 Nov 2012 05:24:17 -0500 From: Stefan Hajnoczi Date: Wed, 21 Nov 2012 11:12:30 +0100 Message-Id: <1353492752-16084-4-git-send-email-stefanha@redhat.com> In-Reply-To: <1353492752-16084-1-git-send-email-stefanha@redhat.com> References: <1353492752-16084-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH 3/5] use int64_t for return values from rbd instead of int List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: qemu-devel@nongnu.org, Stefan Hajnoczi , Stefan Priebe From: Stefan Priebe rbd / rados tends to return pretty often length of writes or discarded blocks. These values might be bigger than int. The steps to reproduce are: mkfs.xfs -f a whole device bigger than int in bytes. mkfs.xfs sends a discard. Important is that you use scsi-hd and set discard_granularity=512. Otherwise rbd disabled discard support. Signed-off-by: Stefan Priebe Signed-off-by: Stefan Hajnoczi --- block/rbd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/rbd.c b/block/rbd.c index 0aaacaf..f3becc7 100644 --- a/block/rbd.c +++ b/block/rbd.c @@ -69,7 +69,7 @@ typedef enum { typedef struct RBDAIOCB { BlockDriverAIOCB common; QEMUBH *bh; - int ret; + int64_t ret; QEMUIOVector *qiov; char *bounce; RBDAIOCmd cmd; @@ -86,7 +86,7 @@ typedef struct RADOSCB { int done; int64_t size; char *buf; - int ret; + int64_t ret; } RADOSCB; #define RBD_FD_READ 0 -- 1.8.0