From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 1/2] vga: fix bochs alignment issue
Date: Wed, 21 Nov 2012 14:48:54 +0100 [thread overview]
Message-ID: <1353505736-26577-3-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1353505736-26577-1-git-send-email-kraxel@redhat.com>
The bochs dispi interface traditionally uses port 0x1ce as 16bit index
register and port 0x1cf as 16bit data register. The later is unaligned,
and probably for that reason the the data register was moved to 0x1d0
for non-x86 archs.
This patch makes the data register available at 0x1d0 on x86 too. The
old x86 location is kept for compatibility reasons, so both 0x1cf and
0x1d0 can be used as data register on x86.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
docs/specs/standard-vga.txt | 3 ++-
hw/vga.c | 3 +--
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/docs/specs/standard-vga.txt b/docs/specs/standard-vga.txt
index 1cecccd..8a4c1e9 100644
--- a/docs/specs/standard-vga.txt
+++ b/docs/specs/standard-vga.txt
@@ -36,7 +36,8 @@ IO ports used
03c0 - 03df : standard vga ports
01ce : bochs vbe interface index port
-01cf : bochs vbe interface data port
+01cf : bochs vbe interface data port (x86 only)
+01d0 : bochs vbe interface data port
Memory regions used
diff --git a/hw/vga.c b/hw/vga.c
index 81aa76b..2b0200a 100644
--- a/hw/vga.c
+++ b/hw/vga.c
@@ -2321,9 +2321,8 @@ static const MemoryRegionPortio vbe_portio_list[] = {
{ 0, 1, 2, .read = vbe_ioport_read_index, .write = vbe_ioport_write_index },
# ifdef TARGET_I386
{ 1, 1, 2, .read = vbe_ioport_read_data, .write = vbe_ioport_write_data },
-# else
- { 2, 1, 2, .read = vbe_ioport_read_data, .write = vbe_ioport_write_data },
# endif
+ { 2, 1, 2, .read = vbe_ioport_read_data, .write = vbe_ioport_write_data },
PORTIO_END_OF_LIST(),
};
--
1.7.1
next prev parent reply other threads:[~2012-11-21 13:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 13:48 [Qemu-devel] [PULL for-1.3 0/2] spice patch queue Gerd Hoffmann
2012-11-21 13:48 ` [Qemu-devel] [PATCH 1/2] Fix the inconsistency in x509-dh-key-file parameter Gerd Hoffmann
2012-11-21 13:48 ` Gerd Hoffmann [this message]
2012-11-21 13:48 ` [Qemu-devel] [PATCH 2/2] spice: add new spice-server callbacks to ui/spice-display.c Gerd Hoffmann
2012-11-21 13:48 ` [Qemu-devel] [PATCH 2/2] vga: fix mmio vga register mapping Gerd Hoffmann
2012-11-21 13:53 ` [Qemu-devel] [PULL for-1.3 0/2] spice patch queue Gerd Hoffmann
2012-11-26 15:34 ` Anthony Liguori
-- strict thread matches above, loose matches on Subject: below --
2012-11-16 13:47 [Qemu-devel] [PULL for-1.3 0/2] vga bugfixes Gerd Hoffmann
2012-11-16 13:47 ` [Qemu-devel] [PATCH 1/2] vga: fix bochs alignment issue Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353505736-26577-3-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).