From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36725) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbB2Y-0007ma-Df for qemu-devel@nongnu.org; Wed, 21 Nov 2012 09:12:35 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TbB2Q-00080p-Cz for qemu-devel@nongnu.org; Wed, 21 Nov 2012 09:12:34 -0500 Received: from mx1.redhat.com ([209.132.183.28]:44591) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbB2Q-00080g-5T for qemu-devel@nongnu.org; Wed, 21 Nov 2012 09:12:26 -0500 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qALECPXh023540 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 21 Nov 2012 09:12:25 -0500 From: Gerd Hoffmann Date: Wed, 21 Nov 2012 15:00:02 +0100 Message-Id: <1353506404-29446-6-git-send-email-kraxel@redhat.com> In-Reply-To: <1353506404-29446-1-git-send-email-kraxel@redhat.com> References: <1353506404-29446-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [PATCH 5/7] usb-smartcard-reader: Properly NAK interrupt eps when we've no events List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Hans de Goede , Alon Levy , Gerd Hoffmann From: Hans de Goede When we've no data to return from the interrupt endpoint, return NAK rather then a 0 length packet. CC: Alon Levy Signed-off-by: Hans de Goede Signed-off-by: Gerd Hoffmann --- hw/usb/dev-smartcard-reader.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/hw/usb/dev-smartcard-reader.c b/hw/usb/dev-smartcard-reader.c index 190fcd6..de955b7 100644 --- a/hw/usb/dev-smartcard-reader.c +++ b/hw/usb/dev-smartcard-reader.c @@ -1002,6 +1002,8 @@ static void ccid_handle_data(USBDevice *dev, USBPacket *p) "handle_data: int_in: notify_slot_change %X, " "requested len %zd\n", s->bmSlotICCState, p->iov.size); + } else { + p->status = USB_RET_NAK; } break; default: -- 1.7.1