From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Igor Mammedov" <imammedo@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH 5/8] qga/channel-posix.c: Include headers it needs
Date: Thu, 22 Nov 2012 15:27:28 -0200 [thread overview]
Message-ID: <1353605251-22218-6-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1353605251-22218-1-git-send-email-ehabkost@redhat.com>
Include:
- <errno.h> for errno
- <unistd.h> & <fcntl.h> for fcntl()
- "osdep.h" for qemu_open()
- <stdlib.h> for exit()
Some of those headers were probably being included by accident because
some other headers were including qemu-common.h, but those headers
should eventually stop including qemu-common.h.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
v2:
qemu-common.h indirectly provided definition for exit(),
so when replacing it with "osdep.h" add explicitly <stdlib.h>
for exit()
---
qga/channel-posix.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/qga/channel-posix.c b/qga/channel-posix.c
index d152827..769a559 100644
--- a/qga/channel-posix.c
+++ b/qga/channel-posix.c
@@ -1,5 +1,10 @@
#include <glib.h>
#include <termios.h>
+#include <errno.h>
+#include <unistd.h>
+#include <fcntl.h>
+#include <stdlib.h>
+#include "osdep.h"
#include "qemu_socket.h"
#include "qga/channel.h"
--
1.7.11.7
next prev parent reply other threads:[~2012-11-22 17:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 17:27 [Qemu-devel] [PATCH 0/8] qemu-common.h header cleanups Eduardo Habkost
2012-11-22 17:27 ` [Qemu-devel] [PATCH 1/8] user: Move *-user/qemu-types.h to main directory Eduardo Habkost
2012-11-22 17:27 ` [Qemu-devel] [PATCH 2/8] user: Rename qemu-types.h to qemu-user-types.h Eduardo Habkost
2012-11-22 17:27 ` [Qemu-devel] [PATCH 3/8] ui/vnc-palette.c: Include headers it needs Eduardo Habkost
2012-11-22 17:27 ` [Qemu-devel] [PATCH 4/8] qapi/qmp-registry.c: " Eduardo Habkost
2012-11-22 17:27 ` Eduardo Habkost [this message]
2012-11-22 17:27 ` [Qemu-devel] [PATCH 6/8] qlist.h: do not include qemu-common.h Eduardo Habkost
2012-11-22 17:27 ` [Qemu-devel] [PATCH 7/8] create qemu-types.h for struct typedefs Eduardo Habkost
2012-11-22 17:27 ` [Qemu-devel] [PATCH 8/8] sysemu.h: include qemu-types.h instead of qemu-common.h Eduardo Habkost
2012-11-26 19:44 ` [Qemu-devel] [PATCH 0/8] qemu-common.h header cleanups Andreas Färber
2012-11-30 20:53 ` Andreas Färber
2012-12-04 8:50 ` Paolo Bonzini
2012-12-04 13:52 ` Andreas Färber
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353605251-22218-6-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=afaerber@suse.de \
--cc=imammedo@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).