From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-trivial@nongnu.org, Yurij Popov <oss@djphoenix.ru>,
patches@linaro.org
Subject: [Qemu-devel] [PATCH] qemu-timer: Don't use RDTSC on 386s and 486s
Date: Fri, 23 Nov 2012 15:12:50 +0000 [thread overview]
Message-ID: <1353683570-30525-1-git-send-email-peter.maydell@linaro.org> (raw)
Adjust the conditional which guards the implementation of
cpu_get_real_ticks() via RDTSC, so that we don't try to use it
on x86 CPUs which don't implement RDTSC. Instead we will fall
back to the no-cycle-counter-available default implementation.
Reported-by: Yurij Popov <oss@djphoenix.ru>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
qemu-timer.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qemu-timer.h b/qemu-timer.h
index da7e97c..e35f163 100644
--- a/qemu-timer.h
+++ b/qemu-timer.h
@@ -169,7 +169,7 @@ static inline int64_t cpu_get_real_ticks(void)
return retval;
}
-#elif defined(__i386__)
+#elif defined(__i586__)
static inline int64_t cpu_get_real_ticks(void)
{
--
1.7.9.5
next reply other threads:[~2012-11-23 15:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-23 15:12 Peter Maydell [this message]
2012-11-23 15:15 ` [Qemu-devel] [PATCH] qemu-timer: Don't use RDTSC on 386s and 486s Paolo Bonzini
2012-11-23 15:17 ` Peter Maydell
2012-11-23 15:31 ` Jamie Lokier
2012-11-23 15:38 ` Peter Maydell
2012-11-23 16:21 ` Jamie Lokier
2012-11-23 15:37 ` Peter Maydell
2012-11-23 16:19 ` Jamie Lokier
2012-11-24 17:39 ` [Qemu-devel] [PATCH] tcg-i386: Improve cmov detection Richard Henderson
2012-11-24 18:12 ` Peter Maydell
2012-11-26 16:23 ` Richard Henderson
2012-12-10 15:42 ` 陳韋任 (Wei-Ren Chen)
2012-11-25 13:44 ` Aurelien Jarno
2012-12-03 13:00 ` [Qemu-devel] [Qemu-trivial] [PATCH] qemu-timer: Don't use RDTSC on 386s and 486s Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353683570-30525-1-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=oss@djphoenix.ru \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).