* [Qemu-devel] [PATCH 1.3] target-i386: restore 'cvt16' CPUID feature
@ 2012-11-26 15:41 Igor Mammedov
2012-11-26 15:45 ` Eduardo Habkost
0 siblings, 1 reply; 2+ messages in thread
From: Igor Mammedov @ 2012-11-26 15:41 UTC (permalink / raw)
To: qemu-devel; +Cc: aliguori, ehabkost, Don, afaerber
commit c8acc380: target-i386/cpu: Name new CPUID bits
by mistake removed CPUID feature while adding new features,
restore it.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
CC: Eduardo Habkost <ehabkost@redhat.com>
---
target-i386/cpu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index a67958e..562d1d8 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -89,7 +89,7 @@ static const char *ext3_feature_name[] = {
"cr8legacy" /* AMD AltMovCr8 */, "abm", "sse4a", "misalignsse",
"3dnowprefetch", "osvw", "ibs", "xop",
"skinit", "wdt", NULL, "lwp",
- "fma4", "tce", NULL, "nodeid_msr",
+ "fma4", "tce", "cvt16", "nodeid_msr",
NULL, "tbm", "topoext", "perfctr_core",
"perfctr_nb", NULL, NULL, NULL,
NULL, NULL, NULL, NULL,
--
1.7.11.7
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH 1.3] target-i386: restore 'cvt16' CPUID feature
2012-11-26 15:41 [Qemu-devel] [PATCH 1.3] target-i386: restore 'cvt16' CPUID feature Igor Mammedov
@ 2012-11-26 15:45 ` Eduardo Habkost
0 siblings, 0 replies; 2+ messages in thread
From: Eduardo Habkost @ 2012-11-26 15:45 UTC (permalink / raw)
To: Igor Mammedov; +Cc: aliguori, qemu-devel, Don, afaerber
On Mon, Nov 26, 2012 at 04:41:18PM +0100, Igor Mammedov wrote:
> commit c8acc380: target-i386/cpu: Name new CPUID bits
> by mistake removed CPUID feature while adding new features,
> restore it.
The feature name was removed on purpose. It was never supported by the
KVM kernel code in any kernel version. See
http://article.gmane.org/gmane.comp.emulators.qemu/176694
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> CC: Eduardo Habkost <ehabkost@redhat.com>
> ---
> target-i386/cpu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
> index a67958e..562d1d8 100644
> --- a/target-i386/cpu.c
> +++ b/target-i386/cpu.c
> @@ -89,7 +89,7 @@ static const char *ext3_feature_name[] = {
> "cr8legacy" /* AMD AltMovCr8 */, "abm", "sse4a", "misalignsse",
> "3dnowprefetch", "osvw", "ibs", "xop",
> "skinit", "wdt", NULL, "lwp",
> - "fma4", "tce", NULL, "nodeid_msr",
> + "fma4", "tce", "cvt16", "nodeid_msr",
> NULL, "tbm", "topoext", "perfctr_core",
> "perfctr_nb", NULL, NULL, NULL,
> NULL, NULL, NULL, NULL,
> --
> 1.7.11.7
>
--
Eduardo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-11-26 15:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-11-26 15:41 [Qemu-devel] [PATCH 1.3] target-i386: restore 'cvt16' CPUID feature Igor Mammedov
2012-11-26 15:45 ` Eduardo Habkost
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).