From: Alexander Graf <agraf@suse.de>
To: "qemu-devel@nongnu.org qemu-devel" <qemu-devel@nongnu.org>
Cc: Blue Swirl <blauwirbel@gmail.com>,
Alexey Kardashevskiy <aik@ozlabs.ru>,
"qemu-ppc@nongnu.org List" <qemu-ppc@nongnu.org>,
Aurelien Jarno <aurelien@aurel32.net>,
David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PATCH 4/6] pseries: Fix bug in PCI MSI allocation
Date: Mon, 26 Nov 2012 19:55:55 +0100 [thread overview]
Message-ID: <1353956157-26879-5-git-send-email-agraf@suse.de> (raw)
In-Reply-To: <1353956157-26879-1-git-send-email-agraf@suse.de>
From: Alexey Kardashevskiy <aik@ozlabs.ru>
In one of the recent reworks to the XICS code, a bug was introduced where
we use the wrong sense and allocate level interrupts instead of message
interrupts for PCI MSIs. This patch fixes it.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Signed-off-by: Alexander Graf <agraf@suse.de>
---
hw/spapr_pci.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/spapr_pci.c b/hw/spapr_pci.c
index a08ed11..3c5b855 100644
--- a/hw/spapr_pci.c
+++ b/hw/spapr_pci.c
@@ -351,7 +351,7 @@ static void rtas_ibm_change_msi(sPAPREnvironment *spapr,
/* There is no cached config, allocate MSIs */
if (!phb->msi_table[ndev].nvec) {
- irq = spapr_allocate_irq_block(req_num, true);
+ irq = spapr_allocate_irq_block(req_num, false);
if (irq < 0) {
fprintf(stderr, "Cannot allocate MSIs for device#%d", ndev);
rtas_st(rets, 0, -1); /* Hardware error */
--
1.6.0.2
next prev parent reply other threads:[~2012-11-26 18:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 18:55 [Qemu-devel] [PULL 1.3 0/6] ppc 1.3 patch queue 2012-11-26 Alexander Graf
2012-11-26 18:55 ` [Qemu-devel] [PATCH 1/6] hw/ide/macio: Fix segfault caused by NULL DMAContext* Alexander Graf
2012-11-26 18:55 ` [Qemu-devel] [PATCH 2/6] PPC: Fix missing TRACE exception Alexander Graf
2012-11-26 18:55 ` [Qemu-devel] [PATCH 3/6] kvm: fix incorrect length in a loop over kvm dirty pages map Alexander Graf
2012-11-26 18:55 ` Alexander Graf [this message]
2012-11-26 18:55 ` [Qemu-devel] [PATCH 5/6] vl.c: Fix broken -usb option Alexander Graf
2012-11-26 18:55 ` [Qemu-devel] [PATCH 6/6] fbdev: fix pixman compile on old pixman Alexander Graf
2012-11-28 21:38 ` [Qemu-devel] [PULL 1.3 0/6] ppc 1.3 patch queue 2012-11-26 Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1353956157-26879-5-git-send-email-agraf@suse.de \
--to=agraf@suse.de \
--cc=aik@ozlabs.ru \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).