From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48086) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Td4Bh-0003P8-DK for qemu-devel@nongnu.org; Mon, 26 Nov 2012 14:17:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Td4Bf-0001D0-0y for qemu-devel@nongnu.org; Mon, 26 Nov 2012 14:17:49 -0500 Received: from cantor2.suse.de ([195.135.220.15]:36828 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Td4Be-0001Ci-Qj for qemu-devel@nongnu.org; Mon, 26 Nov 2012 14:17:46 -0500 From: Alexander Graf Date: Mon, 26 Nov 2012 20:17:42 +0100 Message-Id: <1353957462-27603-3-git-send-email-agraf@suse.de> In-Reply-To: <1353957462-27603-1-git-send-email-agraf@suse.de> References: <1353957462-27603-1-git-send-email-agraf@suse.de> Subject: [Qemu-devel] [PATCH 2/2] sclp: Fix uninitialized var in handle_write_event_buf(). List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "qemu-devel@nongnu.org qemu-devel" Cc: Blue Swirl , Cornelia Huck , Jens Freimann , Aurelien Jarno , Christian Borntraeger From: Cornelia Huck Some gcc versions rightly complain about a possibly unitialized rc, so let's move setting it before the QTAILQ_FOREACH(). Signed-off-by: Cornelia Huck Signed-off-by: Christian Borntraeger Signed-off-by: Jens Freimann Signed-off-by: Alexander Graf --- hw/s390x/event-facility.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/hw/s390x/event-facility.c b/hw/s390x/event-facility.c index 9367660..bc9cea9 100644 --- a/hw/s390x/event-facility.c +++ b/hw/s390x/event-facility.c @@ -112,12 +112,13 @@ static uint16_t handle_write_event_buf(SCLPEventFacility *ef, SCLPEvent *event; SCLPEventClass *ec; + rc = SCLP_RC_INVALID_FUNCTION; + QTAILQ_FOREACH(kid, &ef->sbus.qbus.children, sibling) { DeviceState *qdev = kid->child; event = (SCLPEvent *) qdev; ec = SCLP_EVENT_GET_CLASS(event); - rc = SCLP_RC_INVALID_FUNCTION; if (ec->write_event_data && ec->event_type() == event_buf->type) { rc = ec->write_event_data(event, event_buf); -- 1.6.0.2