qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Lei Li <lilei@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, aliguori@us.ibm.com, armbru@redhat.com,
	Lei Li <lilei@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH] scsi: Remove SCSI_BUS macro
Date: Tue, 27 Nov 2012 13:37:52 +0800	[thread overview]
Message-ID: <1353994672-20714-1-git-send-email-lilei@linux.vnet.ibm.com> (raw)

As step behind Paolo's fix for RHBZ#879657 and according to the current
fix in Commit b5007bc (hmp: do not crash on invalid SCSI hotplug), the
macro SCSI_BUS has already been replaced to object_dynamic_cast which
has been improved when try to cast to NULL value and it is also what
DO_UPCAST macro does. And due to the potential Segmentation risk of
SCSI_BUS, remove this macro.


Signed-off-by: Lei Li <lilei@linux.vnet.ibm.com>
---
 hw/scsi.h |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/hw/scsi.h b/hw/scsi.h
index b8f7357..ad063e5 100644
--- a/hw/scsi.h
+++ b/hw/scsi.h
@@ -142,7 +142,6 @@ struct SCSIBusInfo {
 };
 
 #define TYPE_SCSI_BUS "SCSI"
-#define SCSI_BUS(obj) OBJECT_CHECK(SCSIBus, (obj), TYPE_SCSI_BUS)
 
 struct SCSIBus {
     BusState qbus;
-- 
1.7.7.6

             reply	other threads:[~2012-11-27  5:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-27  5:37 Lei Li [this message]
2012-11-27  8:24 ` [Qemu-devel] [PATCH] scsi: Remove SCSI_BUS macro Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353994672-20714-1-git-send-email-lilei@linux.vnet.ibm.com \
    --to=lilei@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=armbru@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).