From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: afaerber@suse.de, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH v2 18/18] acpi: drop debug port
Date: Tue, 27 Nov 2012 09:59:28 +0100 [thread overview]
Message-ID: <1354006768-13128-19-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1354006768-13128-1-git-send-email-kraxel@redhat.com>
I'm pretty sure this isn't needed any more. I think this predates the
switch to seabios, and the seabios DSDT table has a DBUG() aml macro
which writes stuff to the seabios debug port (0x402).
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/acpi_piix4.c | 9 ---------
1 files changed, 0 insertions(+), 9 deletions(-)
diff --git a/hw/acpi_piix4.c b/hw/acpi_piix4.c
index 263338a..b03454e 100644
--- a/hw/acpi_piix4.c
+++ b/hw/acpi_piix4.c
@@ -38,8 +38,6 @@
# define PIIX4_DPRINTF(format, ...) do { } while (0)
#endif
-#define ACPI_DBG_IO_ADDR 0xb044
-
#define GPE_BASE 0xafe0
#define GPE_LEN 4
@@ -129,11 +127,6 @@ static void apm_ctrl_changed(uint32_t val, void *arg)
}
}
-static void acpi_dbg_writel(void *opaque, uint32_t addr, uint32_t val)
-{
- PIIX4_DPRINTF("ACPI: DBG: 0x%08x\n", val);
-}
-
static void pm_io_space_update(PIIX4PMState *s)
{
uint32_t pm_io_base;
@@ -400,8 +393,6 @@ static int piix4_pm_initfn(PCIDevice *dev)
/* APM */
apm_init(&s->apm, apm_ctrl_changed, s);
- register_ioport_write(ACPI_DBG_IO_ADDR, 4, 4, acpi_dbg_writel, s);
-
if (s->kvm_enabled) {
/* Mark SMM as already inited to prevent SMM from running. KVM does not
* support SMM mode. */
--
1.7.1
prev parent reply other threads:[~2012-11-27 8:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 8:59 [Qemu-devel] [PATCH v2 00/18] acpi: switch to memory api Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 01/18] apci: switch piix4 " Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 02/18] apci: switch ich9 " Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 03/18] apci: switch vt82c686 " Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 04/18] apci: switch timer " Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 05/18] apci: switch cnt " Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 06/18] apci: switch evt " Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 07/18] acpi: cleanup piix4 memory region Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 08/18] acpi: cleanup vt82c686 " Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 09/18] apci: switch ich9 gpe to memory api Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 10/18] apci: switch ich9 smi " Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 11/18] acpi: cleanup ich9 memory region Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 12/18] acpi: switch smbus to memory api Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 13/18] acpi: fix piix4 smbus mapping Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 14/18] apci: switch piix4 gpe to memory api Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 15/18] acpi: remove acpi_gpe_blk Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 16/18] apci: switch piix4 pci hotplug to memory api Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 17/18] q35: update lpc pci config space according to configured devices Gerd Hoffmann
2012-11-27 8:59 ` Gerd Hoffmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354006768-13128-19-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=afaerber@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).