From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: afaerber@suse.de, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH v2 08/18] acpi: cleanup vt82c686 memory region
Date: Tue, 27 Nov 2012 09:59:18 +0100 [thread overview]
Message-ID: <1354006768-13128-9-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1354006768-13128-1-git-send-email-kraxel@redhat.com>
Nothing left to do, everything handled by subregions,
we can zap the reaw/write handlers now.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/vt82c686.c | 61 +--------------------------------------------------------
1 files changed, 1 insertions(+), 60 deletions(-)
diff --git a/hw/vt82c686.c b/hw/vt82c686.c
index 52f46f1..99e6b2f 100644
--- a/hw/vt82c686.c
+++ b/hw/vt82c686.c
@@ -197,65 +197,6 @@ static void pm_tmr_timer(ACPIREGS *ar)
pm_update_sci(s);
}
-static void pm_ioport_writew(void *opaque, uint32_t addr, uint32_t val)
-{
- addr &= 0x0f;
- switch (addr) {
- default:
- break;
- }
- DPRINTF("PM writew port=0x%04x val=0x%02x\n", addr, val);
-}
-
-static uint32_t pm_ioport_readw(void *opaque, uint32_t addr)
-{
- uint32_t val;
-
- addr &= 0x0f;
- switch (addr) {
- default:
- val = 0;
- break;
- }
- DPRINTF("PM readw port=0x%04x val=0x%02x\n", addr, val);
- return val;
-}
-
-static void pm_ioport_writel(void *opaque, uint32_t addr, uint32_t val)
-{
- addr &= 0x0f;
- DPRINTF("PM writel port=0x%04x val=0x%08x\n", addr, val);
-}
-
-static uint32_t pm_ioport_readl(void *opaque, uint32_t addr)
-{
- uint32_t val;
-
- addr &= 0x0f;
- switch (addr) {
- default:
- val = 0;
- break;
- }
- DPRINTF("PM readl port=0x%04x val=0x%08x\n", addr, val);
- return val;
-}
-
-static const MemoryRegionOps pm_io_ops = {
- .old_portio = (MemoryRegionPortio[]) {
- { .offset = 0, .len = 64, .size = 2,
- .read = pm_ioport_readw, .write = pm_ioport_writew },
- { .offset = 0, .len = 64, .size = 4,
- .read = pm_ioport_readl, .write = pm_ioport_writel },
- PORTIO_END_OF_LIST(),
- },
- .valid.min_access_size = 1,
- .valid.max_access_size = 4,
- .impl.min_access_size = 1,
- .impl.max_access_size = 4,
- .endianness = DEVICE_LITTLE_ENDIAN,
-};
-
static void pm_io_space_update(VT686PMState *s)
{
uint32_t pm_io_base;
@@ -415,7 +356,7 @@ static int vt82c686b_pm_initfn(PCIDevice *dev)
apm_init(&s->apm, NULL, s);
- memory_region_init_io(&s->io, &pm_io_ops, s, "vt82c686-pm", 64);
+ memory_region_init(&s->io, "vt82c686-pm", 64);
memory_region_set_enabled(&s->io, false);
memory_region_add_subregion(get_system_io(), 0, &s->io);
--
1.7.1
next prev parent reply other threads:[~2012-11-27 8:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 8:59 [Qemu-devel] [PATCH v2 00/18] acpi: switch to memory api Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 01/18] apci: switch piix4 " Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 02/18] apci: switch ich9 " Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 03/18] apci: switch vt82c686 " Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 04/18] apci: switch timer " Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 05/18] apci: switch cnt " Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 06/18] apci: switch evt " Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 07/18] acpi: cleanup piix4 memory region Gerd Hoffmann
2012-11-27 8:59 ` Gerd Hoffmann [this message]
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 09/18] apci: switch ich9 gpe to memory api Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 10/18] apci: switch ich9 smi " Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 11/18] acpi: cleanup ich9 memory region Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 12/18] acpi: switch smbus to memory api Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 13/18] acpi: fix piix4 smbus mapping Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 14/18] apci: switch piix4 gpe to memory api Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 15/18] acpi: remove acpi_gpe_blk Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 16/18] apci: switch piix4 pci hotplug to memory api Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 17/18] q35: update lpc pci config space according to configured devices Gerd Hoffmann
2012-11-27 8:59 ` [Qemu-devel] [PATCH v2 18/18] acpi: drop debug port Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354006768-13128-9-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=afaerber@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).