From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:40546) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TdjSj-0000Sg-IF for qemu-devel@nongnu.org; Wed, 28 Nov 2012 10:22:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TdjSi-0000pg-IN for qemu-devel@nongnu.org; Wed, 28 Nov 2012 10:22:09 -0500 Received: from mail-pb0-f45.google.com ([209.85.160.45]:59816) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TdjSi-0000pS-CK for qemu-devel@nongnu.org; Wed, 28 Nov 2012 10:22:08 -0500 Received: by mail-pb0-f45.google.com with SMTP id mc8so9266960pbc.4 for ; Wed, 28 Nov 2012 07:22:08 -0800 (PST) Sender: Paolo Bonzini From: Paolo Bonzini Date: Wed, 28 Nov 2012 16:21:46 +0100 Message-Id: <1354116110-28651-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1354116110-28651-1-git-send-email-pbonzini@redhat.com> References: <1354116110-28651-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 1/5] iscsi: fix segfault in url parsing List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Peter Lieven , aliguori@us.ibm.com, Peter Lieven From: Peter Lieven If an invalid URL is specified iscsi_get_error(iscsi) is called with iscsi == NULL. Signed-off-by: Peter Lieven Signed-off-by: Paolo Bonzini --- block/iscsi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/iscsi.c b/block/iscsi.c index a6a819d..5cd8b49 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -947,8 +947,7 @@ static int iscsi_open(BlockDriverState *bs, const char *filename, int flags) iscsi_url = iscsi_parse_full_url(iscsi, filename); if (iscsi_url == NULL) { - error_report("Failed to parse URL : %s %s", filename, - iscsi_get_error(iscsi)); + error_report("Failed to parse URL : %s", filename); ret = -EINVAL; goto out; } -- 1.8.0