From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Michal Privoznik <mprivozn@redhat.com>, aliguori@us.ibm.com
Subject: [Qemu-devel] [PATCH 2/2] nbd-server-add: Fix the default for 'writable'
Date: Wed, 28 Nov 2012 16:30:04 +0100 [thread overview]
Message-ID: <1354116604-32298-3-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1354116604-32298-1-git-send-email-pbonzini@redhat.com>
From: Michal Privoznik <mprivozn@redhat.com>
The documentation to this monitor command tells, that 'writable'
argument is optional and defaults to false. However, the code sets
true as the default. But since some applications may already been
using this, it's safer to fix the code and not documentation which
would break those applications.
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
blockdev-nbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/blockdev-nbd.c b/blockdev-nbd.c
index d1721a3..6b26bbf 100644
--- a/blockdev-nbd.c
+++ b/blockdev-nbd.c
@@ -99,7 +99,7 @@ void qmp_nbd_server_add(const char *device, bool has_writable, bool writable,
}
if (!has_writable) {
- writable = true;
+ writable = false;
}
if (bdrv_is_read_only(bs)) {
writable = false;
--
1.8.0
next prev parent reply other threads:[~2012-11-28 15:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-28 15:30 [Qemu-devel] [PULL 1.3 0/2] NBD updates for 1.3-rc2 Paolo Bonzini
2012-11-28 15:30 ` [Qemu-devel] [PATCH 1/2] nbd: fix use of two uninitialized bytes when connecting to a named export Paolo Bonzini
2012-11-28 15:30 ` Paolo Bonzini [this message]
2012-11-28 21:38 ` [Qemu-devel] [PULL 1.3 0/2] NBD updates for 1.3-rc2 Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1354116604-32298-3-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=mprivozn@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).