qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Igor Mammedov" <imammedo@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"Anthony Liguori" <anthony@codemonkey.ws>
Subject: [Qemu-devel] [RFC 09/10] include qdev code into *-user, too
Date: Fri, 30 Nov 2012 17:27:21 -0200	[thread overview]
Message-ID: <1354303642-4283-10-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1354303642-4283-1-git-send-email-ehabkost@redhat.com>

The code depends on some functions from qemu-option.o, so add
qemu-option.o to universal-obj-y to make sure it's included.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Changes v1 -> v2:
 - Keep files on the hw/ directory
   (it's simply easier to keep them there, as qdev.o depends on irq.o)
 - Add a $(hw-core-obj-y) variable to Makefile.objs for the qdev core code
 - Add irq.o to the list of core qdev files
   (as now the gpio code is being kept inside qdev.c)

Changes v2 -> v3:
 - Add reset.o to hw-core-obj-y
---
 Makefile.objs    |  8 ++++++++
 hw/Makefile.objs | 12 +++++++++---
 2 files changed, 17 insertions(+), 3 deletions(-)

diff --git a/Makefile.objs b/Makefile.objs
index 0a0a33a..8fe4991 100644
--- a/Makefile.objs
+++ b/Makefile.objs
@@ -31,6 +31,13 @@ qom-obj-y = qom/
 universal-obj-y += $(qom-obj-y)
 
 #######################################################################
+# Core hw code (qdev core)
+hw-core-obj-y += hw/
+hw-core-obj-y += qemu-option.o
+
+universal-obj-y += $(hw-core-obj-y)
+
+#######################################################################
 # oslib-obj-y is code depending on the OS (win32 vs posix)
 oslib-obj-y = osdep.o cutils.o qemu-timer-common.o
 oslib-obj-$(CONFIG_WIN32) += oslib-win32.o qemu-thread-win32.o
@@ -253,5 +260,6 @@ nested-vars += \
 	block-obj-y \
 	user-obj-y \
 	common-obj-y \
+	hw-core-obj-y \
 	extra-obj-y
 dummy := $(call unnest-vars)
diff --git a/hw/Makefile.objs b/hw/Makefile.objs
index 0f7bfe0..b81436e 100644
--- a/hw/Makefile.objs
+++ b/hw/Makefile.objs
@@ -1,6 +1,13 @@
+# core qdev-related obj files, also used by *-user:
+hw-core-obj-y += qdev.o qdev-properties.o
+# irq.o needed for qdev GPIO handling:
+hw-core-obj-y += irq.o
+# reset.o used by qdev to register reset handlers:
+hw-core-obj-y += reset.o
+
+
 common-obj-y = usb/ ide/
 common-obj-y += loader.o
-common-obj-y += reset.o
 common-obj-$(CONFIG_VIRTIO) += virtio-console.o
 common-obj-$(CONFIG_VIRTIO) += virtio-rng.o
 common-obj-$(CONFIG_VIRTIO_PCI) += virtio-pci.o
@@ -159,7 +166,6 @@ common-obj-$(CONFIG_SOUND) += $(sound-obj-y)
 common-obj-$(CONFIG_REALLY_VIRTFS) += 9pfs/
 
 common-obj-y += usb/
-common-obj-y += irq.o
 common-obj-$(CONFIG_PTIMER) += ptimer.o
 common-obj-$(CONFIG_MAX7310) += max7310.o
 common-obj-$(CONFIG_WM8750) += wm8750.o
@@ -185,7 +191,7 @@ common-obj-$(CONFIG_SD) += sd.o
 common-obj-y += bt.o bt-l2cap.o bt-sdp.o bt-hci.o bt-hid.o
 common-obj-y += bt-hci-csr.o
 common-obj-y += msmouse.o ps2.o
-common-obj-y += qdev.o qdev-properties.o qdev-monitor.o
+common-obj-y += qdev-monitor.o
 common-obj-y += qdev-properties-system.o
 common-obj-$(CONFIG_BRLAPI) += baum.o
 
-- 
1.7.11.7

  parent reply	other threads:[~2012-11-30 19:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-30 19:27 [Qemu-devel] [RFC 00/10] CPU DeviceState v8 Eduardo Habkost
2012-11-30 19:27 ` [Qemu-devel] [RFC 01/10] create qemu-types.h for struct typedefs Eduardo Habkost
2012-11-30 19:27 ` [Qemu-devel] [RFC 02/10] sysemu.h: include qemu-types.h instead of qemu-common.h Eduardo Habkost
2012-11-30 19:27 ` [Qemu-devel] [RFC 03/10] move -I$(SRC_PATH)/include compiler flag to Makefile.objs Eduardo Habkost
2012-11-30 19:27 ` [Qemu-devel] [RFC 04/10] qdev: qdev_create(): use error_report() instead of hw_error() Eduardo Habkost
2012-11-30 19:27 ` [Qemu-devel] [RFC 05/10] qdev: move reset handler list from vl.c to hw/reset.c Eduardo Habkost
2012-12-03 20:19   ` Igor Mammedov
2012-12-03 21:20   ` Igor Mammedov
2012-12-03 22:46     ` Eduardo Habkost
2012-11-30 19:27 ` [Qemu-devel] [RFC 06/10] qdev: add stubs for vmstate register/unregister functions Eduardo Habkost
2012-12-03 21:49   ` Igor Mammedov
2012-12-04 12:49     ` Eduardo Habkost
2012-12-04 13:08       ` Paolo Bonzini
2012-11-30 19:27 ` [Qemu-devel] [RFC 07/10] qdev: add sysbus_get_default() stub Eduardo Habkost
2012-11-30 19:27 ` [Qemu-devel] [RFC 08/10] qdev-properties.c: separate core from the code used only by qemu-system-* Eduardo Habkost
2012-11-30 19:27 ` Eduardo Habkost [this message]
2012-11-30 19:27 ` [Qemu-devel] [RFC 10/10] qom: make CPU a child of DeviceState Eduardo Habkost

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1354303642-4283-10-git-send-email-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=afaerber@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=imammedo@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).